not comments added

[qinritukou]

It seemed not comments added by ddl was added to server. I'm using postgres.

[jflambert]

Comments identified by "--" seem to get added for me, no problem (postgresql 11)

However, blank lines disappear. I'm creating an issue about this.

[mfridman]

@qinritukou can you confirm this is still an issue?

If so, what postgres version? Do you have a basic example of observed vs expected?

There is a sep. ticket on empty lines.. #200

[tvarsis]

What I have found is that it seems to keep -- single line comments (at least when there is no blank row after it), but seems to remove multi line -- comments, especially if they have blank rows above/after them. This issue and the white space/blank row issue seems to both have been coming in version 2.7.0. Prior to this, I think all comments and white space was preserved correctly.

Here you can see an example. Left hand is the original function, and right hand is what is actually getting inserted in the db by goose, where you can see single line comment preserved, multi line and blank row/white space removed:

[tvarsis]

This is a pretty big issue, since I think many people might have the same workflow as me, or at least, want to be able to rely on diff tools. My workflow is this: Do a db diff with a diff tool -> Generate and validate migration scripts -> Run migrations with Goose

The problem with not using the same comment structure with the same white space, is that all of those comments/functions etc will then again show up in the db diff, even though they are actually suppose to be identical. Goose changing of white space and comments breaks the whole db diff flow to be able to detect differences between migrations.