gitfs icon indicating copy to clipboard operation
gitfs copied to clipboard

Special characters in folder names aren't properly treated

Open pdobrescu opened this issue 9 years ago • 7 comments

When a folder (and maybe a file too) contains special characters, its parent folder cannot be listed.

E.g. the folder abc contains the sub-folder called ghí. Because of the í, running ls on abc returns:

ls: reading directory .: Bad address

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

pdobrescu avatar Apr 17 '15 13:04 pdobrescu

Can't reproduce. Can you give another example?

vtemian avatar May 19 '15 14:05 vtemian

Nope, this was the only case. Just to make it clear: one of the folders in the themes sub-folder was named ghí. And because of that I couldn't list or browse the themes folder.

pdobrescu avatar May 20 '15 05:05 pdobrescu

Try to monkey test gitfs with different sftp clients

vtemian avatar May 25 '15 11:05 vtemian

13:29:56 Status:           Starting upload of /Users/pedro/BT-Sync/PressLabs/Themes/Blogit/blogit-wp/inc/nc-options/options/validation/no_html/validation_no_html.php
13:29:56 Command:     cd "/dobrestii/current/wp-content/root/dslkf sdfkjs fsdkj/Another ghí folder with spaces this time and a very very long name that has a big number of very weird characters. Yes we can have such customers :) ®†`˙©∆∫µ˜/blogit-wp/inc/nc-options/options/validation/no_html"
13:29:56 Error:             Directory /dobrestii/current/wp-content/root/dslkf sdfkjs fsdkj/Another ghí folder with spaces this time and a very very long name that has a big number of very weird characters. Yes we can have such customers :) ®†`˙©∆∫µ˜/blogit-wp/inc/nc-options/options/validation/no_html: no such file or directory
13:29:56 Command:     cd "/dobrestii/current/wp-content/root/dslkf sdfkjs fsdkj/Another ghí folder with spaces this time and a very very long name that has a big number of very weird characters. Yes we can have such customers :) ®†`˙©∆∫µ˜/blogit-wp/inc/nc-options/options/validation"
13:29:56 Error:             Directory /dobrestii/current/wp-content/root/dslkf sdfkjs fsdkj/Another ghí folder with spaces this time and a very very long name that has a big number of very weird characters. Yes we can have such customers :) ®†`˙©∆∫µ˜/blogit-wp/inc/nc-options/options/validation: no such file or directory
13:29:56 Command:     cd "/dobrestii/current/wp-content/root/dslkf sdfkjs fsdkj/Another ghí folder with spaces this time and a very very long name that has a big number of very weird characters. Yes we can have such customers :) ®†`˙©∆∫µ˜/blogit-wp/inc/nc-options/options"
13:29:56 Response:     New directory is: "/dobrestii/current/wp-content/root/dslkf sdfkjs fsdkj/Another ghí folder with spaces this time and a very very long name that has a big number of very weird characters. Yes we can have such customers :) ®†`˙©∆∫µ˜/blogit-wp/inc/nc-options/options”
13:29:56 Command:     mkdir "validation"
13:29:56 Error:             mkdir /dobrestii/current/wp-content/root/dslkf sdfkjs fsdkj/Another ghí folder with spaces this time and a very very long name that has a big number of very weird characters. Yes we can have such customers :) ®†`˙©∆∫µ˜/blogit-wp/inc/nc-options/options/validation: failure
13:29:56 Command:     mkdir "/dobrestii/current/wp-content/root/dslkf sdfkjs fsdkj/Another ghí folder with spaces this time and a very very long name that has a big number of very weird characters. Yes we can have such customers :) ®†`˙©∆∫µ˜/blogit-wp/inc/nc-options/options/validation/no_html"
13:29:56 Response:     mkdir /dobrestii/current/wp-content/root/dslkf sdfkjs fsdkj/Another ghí folder with spaces this time and a very very long name that has a big number of very weird characters. Yes we can have such customers :) ®†`˙©∆∫µ˜/blogit-wp/inc/nc-options/options/validation/no_html: OK
13:29:56 Command:     cd "/dobrestii/current/wp-content/root/dslkf sdfkjs fsdkj/Another ghí folder with spaces this time and a very very long name that has a big number of very weird characters. Yes we can have such customers :) ®†`˙©∆∫µ˜/blogit-wp/inc/nc-options/options/validation/no_html"
13:29:56 Response:     New directory is: "/dobrestii/current/wp-content/root/dslkf sdfkjs fsdkj/Another ghí folder with spaces this time and a very very long name that has a big number of very weird characters. Yes we can have such customers :) ®†`˙©∆∫µ˜/blogit-wp/inc/nc-options/options/validation/no_html"
13:29:56 Status:           Retrieving directory listing of "/dobrestii/current/wp-content/root/dslkf sdfkjs fsdkj/Another ghí folder with spaces this time and a very very long name that has a big number of very weird characters. Yes we can have such customers :) ®†`˙©∆∫µ˜/blogit-wp/inc/nc-options/options/validation/no_html"...
13:29:56 Command:     ls
13:29:56 Status:           Listing directory /dobrestii/current/wp-content/root/dslkf sdfkjs fsdkj/Another ghí folder with spaces this time and a very very long name that has a big number of very weird characters. Yes we can have such customers :) ®†`˙©∆∫µ˜/blogit-wp/inc/nc-options/options/validation/no_html
13:29:56 Command:     put "/Users/pedro/BT-Sync/PressLabs/Themes/Blogit/blogit-wp/inc/nc-options/options/validation/no_html/validation_no_html.php" "validation_no_html.php"
13:29:56 Status:           local:/Users/pedro/BT-Sync/PressLabs/Themes/Blogit/blogit-wp/inc/nc-options/options/validation/no_html/validation_no_html.php => remote:/dobrestii/current/wp-content/root/dslkf sdfkjs fsdkj/Another ghí folder with spaces this time and a very very long name that has a big number of very weird characters. Yes we can have such customers :) ®†`˙©∆∫µ˜/blogit-wp/inc/nc-options/options/validation/no_html/validation_no_html.php
13:29:56 Status:           File transfer successful, transferred 934 bytes in 1 second

vtemian avatar Jun 18 '15 10:06 vtemian

I managed to crash it using FileZilla. Here's the FileZilla log to check the operations I've done:

https://gist.github.com/pdobrescu/f3c7c2949ce632e3b054

pdobrescu avatar Jun 18 '15 11:06 pdobrescu

I am totally new to github. Can anyone help me that how can I contribute to open sources. I read a lot of articles, pages but didn't understand well. Thank you.....

Blank000 avatar Feb 15 '17 02:02 Blank000

Hey blank000 did you figure it out? Here is a good [resource] (https://help.github.com/articles/creating-a-pull-request-from-a-fork/)! @Blank000

leahlang4d avatar Oct 05 '17 04:10 leahlang4d