searchit icon indicating copy to clipboard operation
searchit copied to clipboard

Compatibility with Craft 3.4

Open bencroker opened this issue 5 years ago • 8 comments

With the redesigned UI in Craft 3.4, the Searchit plugin is broken. Specifically, the _elements/indexcontainer template has been renamed to _elements/toolbar, likely along with some other changes.

Renaming the template fixes the issue, however the layout needs some adjusting.

Screenshot 2020-01-06 at 15 23 22

This is with Craft 3.4.beta-5

bencroker avatar Jan 06 '20 13:01 bencroker

Thanks for reporting @bencroker

samhibberd avatar Jan 06 '20 17:01 samhibberd

@samhibberd any update?

verbeeksteven avatar Jan 30 '20 15:01 verbeeksteven

Looks like it was fixed in CraftCMS (https://github.com/craftcms/cms/commit/043a24f339e319f489cee15c8b6025772587e5c9) though it is deprecated and should be fixed

verbeeksteven avatar Jan 31 '20 18:01 verbeeksteven

In Craft 3.4, the element index layout also removed the toolbar and elementindex classes, so Searchit's CSS for the Max Filter Width and Compact Mode settings no longer applies.

bencarr avatar Mar 11 '20 16:03 bencarr

Posting to subscribe to this. Currently still an issue with 3.4.11. Really hope to see this fixed soon.

johndwells avatar Mar 28 '20 23:03 johndwells

Add me to the list of folks excited to see a fix for this.

brettburwell avatar Apr 09 '20 06:04 brettburwell

p.s. For anyone looking for a quick and partial fix, you can use the excellent Control Panel CSS plugin to apply a max-width to Searchit's select menu (which was my primary issue).

Here's the CSS in case it's helpful to anyone else:

.searchit--filters select {
  max-width: 120px;
}

brettburwell avatar Apr 09 '20 06:04 brettburwell

I've been using my own fork which works great with Craft 3.4.x. Just submitted a PR, but for anyone who wants to get it right away, add this to your composer.json:

  "require": {
    "fruitstudios/searchit": "dev-master",

and

  "repositories": [
    {
      "type": "vcs",
      "url": "https://github.com/bencroker/craft-searchit"
    }
  ]

Then run composer update.

bencroker avatar Apr 09 '20 07:04 bencroker