pressbooks-book icon indicating copy to clipboard operation
pressbooks-book copied to clipboard

Enforce table style consistency across themes, classes, and formats

Open mcgratay opened this issue 5 years ago • 0 comments

Description

Table styles are inconsistent across themes, table classes, and book formats. A "Standard" class table template should look the same in a McLuhan PDF as it does in a Leonard webbook, with only minor variations on typeface to suit the theme.

Standard class:

  • Horizontal lines on top and bottom of the table
  • No vertical lines
  • No horizontal lines between items within the table Screen Shot 2020-02-03 at 2 56 09 PM

No Lines class:

  • No horizontal lines
  • No vertical lines Screen Shot 2020-02-03 at 2 56 58 PM Note that this is a deviation from the Buckram standard

Lines class:

  • Horizontal lines on top and bottom
  • Horizontal lines between each item
  • No vertical lines Screen Shot 2020-02-03 at 2 58 18 PM

Shaded class:

  • Horizontal lines on top and bottom
  • No horizontal lines between items
  • No vertical lines
  • Shaded background Screen Shot 2020-02-03 at 2 59 03 PM

Full grid:

  • Border on all four sides
  • Horizontal lines between all items
  • Vertical lines between all items Screen Shot 2020-02-03 at 2 59 41 PM

Current state of supported themes: Adunis: Web:

  • Standard is wrong [does not have top and bottom lines]
  • Lines is wrong [has no lines at all]
  • Shaded is wrong if based on Standard [does not have top and bottom lines] PDF:
  • Standard is wrong [does not have top and bottom lines]
  • Lines is wrong [has no lines at all]
  • Shaded is wrong if based on Standard [does not have top and bottom lines] Ebook:
  • Standard is wrong [does not have top and bottom lines]
  • Lines is wrong [has no lines at all]
  • Shaded is wrong if based on Standard [does not have top and bottom lines] MOBI:
  • Standard is wrong [does not have top and bottom lines but does have horizontal lines between items]
  • Lines is wrong [has no lines at all]
  • Shaded is wrong if based on Standard [does not have top and bottom lines]

Andreesen: Web:

  • Standard is wrong [does not have top and bottom lines, but does have horizontal lines between items]
  • Lines is wrong [no line at all]
  • Shaded is wrong if based on Standard [does not have top and bottom lines, but does have horizontal lines between items] PDF:
  • Standard is wrong [does not have top and bottom lines, but does have horizontal lines between items]
  • Lines is wrong [no lines at all]
  • Shaded is wrong if based on Standard [does not have top and bottom lines, but does have horizontal lines between items] Ebook:
  • Standard is wrong [does not have top and bottom lines, but does have horizontal lines between items]
  • Lines is wrong [no lines at all]
  • Shaded is wrong [does not have top and bottom lines, but does have horizontal lines between items]

Asimov: Web:

  • no lines is wrong [has top and bottom lines] PDF: [none of the classes except full grid have lines at all]
  • Standard is wrong [no lines at all]
  • Lines is wrong [no lines at all]
  • Shaded is wrong [no lines at all] Ebook:
  • No lines is wrong [top and bottom lines only]
  • Lines is wrong [only has top and bottom lines; should have no lines]

Atwood: Web:

  • no lines is wrong [has top and bottom lines] PDF:
  • no lines is wrong [has top and bottom lines] Ebook:
  • no lines is wrong [has top and bottom lines]

Austen: Web:

  • no lines is wrong [has top and bottom lines] PDF:
  • no lines is wrong [has top and bottom lines] Ebook:
  • Lines is wrong [class only shows top and bottom lines]

Baker: Web:

  • no lines is wrong [has top and bottom lines] PDF:
  • no lines is wrong [has top and bottom lines] Ebook:
  • standard is wrong [no lines at all]
  • lines is wrong [no lines at all]
  • shaded is wrong [no lines at all]

Bradbury: Web:

  • no lines is wrong [has top and bottom lines] PDF:
  • standard is wrong [no top and bottom lines; does have lines between items]
  • shaded is wrong [no top and bottom lines; does have lines between items] EPUB:
  • standard is wrong [no top and bottom lines; does have lines between items]
  • shaded is wrong [no top and bottom lines; does have lines between items]

Bronte: Web:

  • no lines is wrong [has top and bottom lines] PDF:
  • no lines is wrong [has top and bottom lines] Ebook:
  • no lines is wrong [has top and bottom lines]
  • lines is wrong [only has top and bottom lines] *These results are from Textopress, which has a newer version of Bronte. Results would be different from the current production network version of Bronte.

Bukowski: Web:

  • standard is wrong [no lines at all]
  • shaded is wrong [no lines at all]
  • full grid is wrong [no lines at all] PDF:
  • no lines is wrong [has top and bottom lines]
  • full grid is wrong [only top and bottom lines] Ebook:
  • standard is wrong [no top and bottom lines; yes horizontal lines between items]
  • lines is wrong [no top and bottom lines]
  • shaded is wrong [no top and bottom lines]
  • full grid is wrong [no top and bottom lines] NOTE: full grid doesn’t necessarily work for non-Buckram themes, so those results are expected

Christie: Web:

  • no lines is wrong [has top and bottom lines] PDF:
  • no lines is wrong [has top and bottom lines] Ebook:
  • no lines is wrong [has top and bottom lines]
  • lines is wrong [only top and bottom lines]

Clarke: Web:

  • standard is wrong [no lines at all]
  • lines is wrong [no lines at all]
  • shaded is wrong [no lines at all] PDF:
  • standard is wrong [no lines at all]
  • lines is wrong [no lines at all]
  • shaded is wrong [no lines at all] Ebook:
  • no lines is wrong [has top and bottom lines]
  • lines is wrong [only top and bottom lines]

Cleary: Web:

  • standard is wrong [no lines at all]
  • shaded is wrong [no lines at all; not shaded]
  • full grid is wrong [no lines at all] PDF:
  • no lines is wrong [has top and bottom lines]
  • full grid is wrong [only top and bottom lines] Ebook:
  • standard is wrong [no top line; does have lines between items]
  • lines is wrong [no top line]
  • shaded is wrong [no top line]
  • full grid is wrong [no top line] NOTE: full grid doesn’t necessarily work for non-Buckram themes, so those results are expected

Dillard: Web:

  • no lines is wrong [has top and bottom lines] PDF:
  • no lines is wrong [has top and bottom lines] Ebook:
  • no lines is wrong [has top and bottom lines]

*Donham: Web:

  • no lines is wrong [has top and bottom lines] PDF:
  • no lines is wrong [has top and bottom lines] Ebook:
  • standard is wrong [mimics lines class and has lines between each item]
  • no lines is wrong [has top and bottom lines…so it’s like the Buckram default]
  • shaded is wrong [mimics line class and has lines between each item] *These results are from Textopress, which has a newer version of Donham. Results would be different from the current production network version of Donham.

Graham: Web:

  • no lines is wrong [has top and bottom lines] PDF:
  • no lines is wrong [has top and bottom lines] Ebook:
  • no lines is wrong [has top and bottom lines]
  • lines is wrong [doesn’t have lines between items]

Jacobs: Web:

  • no lines is wrong [has top and bottom lines] PDF:
  • standard is wrong [no lines at all]
  • lines is wrong [no lines at all]
  • shaded is wrong [no lines at all] Ebook:
  • no lines is wrong [has top and bottom lines]
  • lines is wrong [no lines between items]

Kolbert: Web:

  • standard is wrong [no lines at all]
  • shaded is wrong [no lines at all]
  • full grid is wrong [no lines at all] PDF:
  • standard is wrong [no top line; lines between items]
  • shaded is wrong [no top line; lines between items]
  • full grid is wrong [no top line] Ebook:
  • standard is wrong [no top line; lines between items]
  • lines is wrong [no top line]
  • shaded is wrong [no top line]
  • full grid is wrong [no top line] NOTE: full grid doesn’t necessarily work for non-Buckram themes, so those results are expected

Leonard: Web:

  • no lines is wrong [has top and bottom lines] PDF:
  • no lines is wrong [has top and bottom lines] Ebook:
  • no lines is wrong [has top and bottom lines]
  • lines is wrong [no lines between items]

Lewis: Web:

  • standard is wrong [no lines at all]
  • shaded is wrong [no lines at all]
  • full grid is wrong [no lines at all] PDF:
  • no lines is wrong [has top and bottom lines]
  • full grid is wrong [no lines between items; no vertical lines] Ebook:
  • standard is wrong [no top line]
  • lines is wrong [no top line]
  • shaded is wrong [no top line]
  • full grid is wrong [no top line] NOTE: full grid doesn’t necessarily work for non-Buckram themes, so those results are expected

Malala: Web:

  • no lines is wrong [has top and bottom lines] PDF:
  • no lines is wrong [has top and bottom lines] Ebook:
  • no lines is wrong [has top and bottom lines]
  • lines is wrong [doesn’t have horizontal lines between items]

McLuhan: Web:

  • no lines is wrong [has top and bottom lines] PDF:
  • no lines is wrong [has top and bottom lines] Ebook:
  • no lines is wrong [has top and bottom lines]
  • lines is wrong [doesn’t have horizontal lines in between items]

Notes:

  • Lines is wrong in Adobe Digital Editions for several themes. Only the top and bottom lines of the table are displayed. These tables look fine in MOBI format on Kindle, and in EPUB format on other ebook reader software like iBooks. Whatever it is that lets “Lines” class tables display fine in ADE for Bradbury, Dillard, and Donham should be copied into the other themes.
  • There are some themes that won’t display at all in ADE. This issue will be opened as a separate ticket, but for testing purposes note that Atwood, Donham, Bradbury, and Andreesen should be tested on iBooks or another ebook software.
  • Some themes are not yet converted to Buckram; for those themes, the full grid class won’t work
  • In some themes the “No Lines” class has no lines. In some themes, it does have lines. The latter is technically correct: “No Lines” class is supposed to look like the Standard class and include horizontal lines on top and bottom. However, I’m proposing that the “No Lines” class be changed in Buckram to have no lines, so that the class isn’t redundant and better meets users’ expectations.
  • Generally, the idea is to follow the McLuhan (Buckram) default, EXCEPT for the “No Lines” class

Example book:https://tables.textopress.com/ Errors in spreadsheet format: https://docs.google.com/spreadsheets/d/1DDI2n0swft3os2yL_qX11STijkB5zEIllA1TL99LIzI/edit?usp=sharing

Steps to Reproduce

  1. Create a table
  2. Add a class
  3. Save and export to all formats

Expected behavior: Table classes are consistent across themes and formats.

Actual behavior: There are many variations in table class display.

mcgratay avatar Feb 03 '20 20:02 mcgratay