Justin Collins comments

Results 213 comments of


                                            Justin Collins

Allow Brakeman to determine the Rails configuration by querying `Rails.application.config`

This would require Brakeman to load and execute code from the application (not to mention to be compatible with doing so), which is against Brakeman's design principles (and a little...

[#1942]Add support for Rails configuration modules

Seems reasonable!

Ignore polymorphic_name in SQL

Do you want to open a PR for this?

`Brakeman::SexpProcessor#process`: Type should be a Symbol

I can reproduce, thanks! Taking a look.

Fix enum support

Brakeman still needs to support the older API for enums. I'm not sure why you moved the Gemfile for the Rails 7 test app, there shouldn't be any need to...

Fix enum support

No need to add duplicate tests to different test apps. You've only added new instances of the old-style API, so that's why the new code is not being exercised. `to_test.rb`...

Brakeman enum support broken?

Yes... looks like the enum API changed in Rails 7.1.

[Format Error] on code field with Prism parser- Brakeman v7.0.2

Are you definitely using Prism 1.4.0? Can you share the code that looks something like `Arel.sql("#{start_of_week_sql("created_at")} as monday, #{working_minutes_sql("created_at", "merchant_responded_at")} AS merchant_reaction")` ?

Improve performance traversing files

I think it might make more sense to change ```ruby find_paths("**", "*.{erb,haml,slim}").reject { |path| File.basename(path).count(".") > 1 } ``` to ```ruby find_paths(".", "*.{erb,haml,slim}").reject { |path| File.basename(path).count(".") > 1 } ```...

Improve performance traversing files

@mhenrixon can you try the above suggestion?