vim-textobj-quote icon indicating copy to clipboard operation
vim-textobj-quote copied to clipboard

Published 20 hours ago • verified publisher icon preservim

Using surround to change into typographic quotes work. The other way around doesn't

Open rafaeln opened this issue 7 years ago • 11 comments

When you have 'something' and you do cs'q on it, you do get “something”, but when you have “something” and you do csq' on it, you don't get any change.

rafaeln avatar Oct 19 '16 18:10 rafaeln

I'll see if I can reproduce this. Thanks.

reedes avatar Nov 08 '16 00:11 reedes

I'm on vim 8.0 and getting the same error

dbaynard avatar Dec 03 '16 14:12 dbaynard

Also: dsq/dsQ don't work.

Porges avatar Jan 09 '17 05:01 Porges

I finally installed Tim Pope's surround plugin after not using it for a few years.

Changing from straight to curly works, but the reverse does not. So I'm seeing the same thing you are.

My apologies, as it's been so long since I last dealt with this that I can't even recall if it did work both ways. However, if somebody wants to dig into this and get it working, I'd be happy to accept a pull request.

reedes avatar Jan 12 '17 01:01 reedes

After looking at the code it seems like surround.vim doesn't support this... I could have sworn it used to work! 🙂

Here's the issue on surround: https://github.com/tpope/vim-surround/issues/210

Porges avatar Jan 13 '17 03:01 Porges

This works for me now. I have no idea when or how the fix took place — maybe it's my fork of tpope's pluign?

Is anybody else still experiencing this?

alerque avatar Jun 01 '20 07:06 alerque

I'm inclined to close this. (Nearly two years without any responses.)

/ping @alerque

telemachus avatar Feb 09 '22 22:02 telemachus

Yup. Still no repro here. If anybody is still having this issue please comment and we'll review your situation.

alerque avatar Feb 11 '22 16:02 alerque

Hate to re-open this right after it was closed, but I'm having this issue. vim-surround commit baf89ad, vim-textobj-quote commit 7ce5b32, vim-textobj-user commit 41a675d.

andrew-vant avatar Feb 18 '22 17:02 andrew-vant

@andrew-vant Fair enough. I'm guessing you are a victim of https://github.com/tpope/vim-surround/issues/210, you can try my fork here. I'm guessing that's why I can't repro this.

alerque avatar Feb 18 '22 20:02 alerque

Should we add a test for this? Or is it something that we can't fix, so testing for it effectively doesn't matter?

I haven't used surround in years (I use vim-sandwich instead, which—as a side note—I recommend very highly), but I will try to look into this when I can, though it sounds like we can't fix it from our end.

telemachus avatar Feb 18 '22 21:02 telemachus