nerdtree icon indicating copy to clipboard operation
nerdtree copied to clipboard

Vim 9.0 menu patch

Open santiagovrancovich opened this issue 2 years ago • 5 comments

EDIT:

This is only open for historical reasons and to make it easier to find.

This PR is a hotfix for the issue mentioned in #1321. There is a problem in the early versions of Vim9 which prevents some parts of NERDTree from restoring their original size after a temporary window/pane resize. This patch forces a manual resize so deal with this issue. I suggest you update your Vim if you are experiencing this problem instead of using this patch.

TL;DR Just update your Vim!

Description of Changes

Force resize after closing the menu to prevent issue #1321


New Version Info

Author's Instructions

  • [ ] Derive a new MAJOR.MINOR.PATCH version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • [ ] Update CHANGELOG.md, following the established pattern.

Collaborator's Instructions

  • [ ] Review CHANGELOG.md, suggesting a different version number if necessary.
  • [ ] After merging, tag the commit using these (Mac-compatible) bash commands:
    git checkout master
    git pull
    sed -n "$(grep -n -m2 '####' CHANGELOG.md | cut -f1 -d: | sed 'N;s/\n/,/')p" CHANGELOG.md | sed '$d'
    git tag -a $(read -p "Tag Name: " tag;echo $tag) -m"$(git show --quiet --pretty=%s)";git push origin --tags
    

santiagovrancovich avatar Aug 27 '22 01:08 santiagovrancovich

I have tested this locally, and it is working properly for me.

# vim --version
VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Aug 17 2022 21:21:22)
macOS version - arm64
Included patches: 1-217
# git head
commit fc85a6f07c2cd694be93496ffad75be126240068 (HEAD -> master, origin/master, origin/HEAD)
Author: Rod Elias <[email protected]>
Date:   Mon Jun 13 07:10:46 2022 -0300

softwaregravy avatar Oct 22 '22 20:10 softwaregravy

Tested locally, works for me on Neovim 0.8.0. Please merge ASAP, because having screen real estate eaten by this bug is annoying.

dqnk avatar Nov 03 '22 16:11 dqnk

What are the actual blockers to getting this merged and released?

sukima avatar Apr 15 '23 02:04 sukima

I think someone just needs to click the merge button. From what I remember though, NERDTree has been looking to transition its maintainer for a while. I don't know how successful that process has been

igbanam avatar Apr 16 '23 22:04 igbanam

This issue was patched by Vim in newer versions, it just affected a few 9.0 releases, this pull request is still up so people can patch it locally if they decide to keep using older versions of Vim.

santiagovrancovich avatar Apr 16 '23 22:04 santiagovrancovich