premkumar bhaskal
premkumar bhaskal
@peschmae I am bit stuck with other stuff, but I can review it over weekend. but you can go ahead and put up a PR if you want some early...
I am unable to check it still, so removed assignee.
@ernstvonoelsen Could you please post some testing output if you have done? Does the description prints the absolute path now? I thought the main issue in #895 was that relative...
I think it cannot. If you see here https://carvel.dev/ytt/docs/v0.49.x/how-it-works/ , overlay works on top of evaluated templates. Evaluated templates cannot have function definition because ytt does not emit comments, and...
Thank you for reporting the issue. I am checking the PR.
@scastria You can pass stepname using closure. I will see if this can be done in a better way somehow. ``` #@ load("@ytt:overlay", "overlay") #@ def parallelc(stepname): #@ def parallel(i,...
one comment based on my first glance. currently if both serviceAccount and cluster are specified in a PackageInstall CRD, the serviceAccount is read and used. if none are specified, we...
~~all seems fine.~~ Well test is failing actually.
I think test is failing because k8s version of minikube is set to 1.20 which does not support CEL validation. https://github.com/carvel-dev/kapp-controller/blob/b4886dfaff8050fc7221e1d7bce9e69e2a4264e3/.github/workflows/test-gh.yml#L49
> cel_validation_test.go:26: Error getting Kubernetes version: unable to load in-cluster configuration, KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT must be defined failing because the test code is not running on the kind cluster.