premake-core icon indicating copy to clipboard operation
premake-core copied to clipboard

Bootstrap improvements

Open tritao opened this issue 1 year ago • 2 comments

What does this PR do?

Adds a new Bootstrap.sh script to simplify bootstrap in non-Windows platforms. Re-uses all the bootstrap scripts for CI to make sure they are well tested.

How does this PR change Premake's behavior?

I updated CI to use vs2022 as MSDEV. Previously we were using vs2019, however if you pass that to Bootstrap.bat then vswhere.exe cannot find VS.

AFACT there is no point in forcing Premake to generate vs2019 files to build with MSVC 2022.

So either we just pass an empty value so it auto detects latest MSVC, or pass it explicitly as part of a matrix as I've done.

tritao avatar Oct 10 '24 14:10 tritao

All builds are passing however there is something going on with the CI report, the Windows expected checks are not turning green, I think due to me adding the msdev matrix?

Are those setup manually on the repo by any chance? Any idea @samsinsane?

EDIT: Maybe it just looks at the current master workflow for those and it will be okay to merge as-is?

tritao avatar Oct 10 '24 14:10 tritao

I think it is related to https://github.com/premake/premake-core/pull/2279 They have to also change config rule settings so "CI Workflow / ci (pull_request)" is the required one, instead of the others.

Ping @samsinsane

Jarod42 avatar Oct 10 '24 14:10 Jarod42

@tritao It looks like the statusing hung. Could you push up an empty commit to retrigger CI?

nickclark2016 avatar Oct 25 '24 03:10 nickclark2016

@tritao It looks like the statusing hung. Could you push up an empty commit to retrigger CI?

I've already tried that on a previous PR, even tried opening a whole new PR (this is the second one I opened, due to trying to fix that issue). I think it must be due to some kind of manual setup that was done on Acttions settings?

tritao avatar Oct 25 '24 10:10 tritao

@tritao @Jarod42 @nickclark2016 CI checks have been updated.

samsinsane avatar Oct 31 '24 03:10 samsinsane