premake-core icon indicating copy to clipboard operation
premake-core copied to clipboard

Fix Codelite/gmake2 `buildmessage` escaping.

Open Jarod42 opened this issue 3 years ago • 1 comments

What does this PR do?

Fix escaping for buildmessage for gmake2 and codelite

How does this PR change Premake's behavior?

Escape double quote and backslash in quoted

Anything else we should know?

Tested with https://github.com/Jarod42/premake-sample-projects/actions with branch custom_rule_check_quote_in_message

Did you check all the boxes?

  • [x] Focus on a single fix or feature; remove any unrelated formatting or code changes
  • [x] Add unit tests showing fix or feature works; all tests pass
  • [ ] Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • [x] Follow our coding conventions
  • [x] Minimize the number of commits
  • [ ] Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Jarod42 avatar Jul 17 '22 14:07 Jarod42

[ FAILED ] premake_http.https_get_verify_peer HTTP response code said error The requested URL returned error: 504 Gateway Time-out

Unrelated to my changes. :-) Not the first time that those tests failed randomly BTW.

Jarod42 avatar Aug 06 '22 13:08 Jarod42