premake-core icon indicating copy to clipboard operation
premake-core copied to clipboard

Nvidia compiler support

Open abel0b opened this issue 3 years ago • 8 comments

What does this PR do?

Add a new toolset module for Nvidia HPC C/C++ compiler (Closes #1874).

How does this PR change Premake's behavior?

No breaking change.

Anything else we should know?

I only tested that the new toolset can compile premake on my linux machine using gmake2 exporter.

Did you check all the boxes?

  • [x] Focus on a single fix or feature; remove any unrelated formatting or code changes
  • [ ] Add unit tests showing fix or feature works; all tests pass
  • [x] Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • [x] Follow our coding conventions
  • [x] Minimize the number of commits
  • [ ] Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

abel0b avatar May 14 '22 06:05 abel0b

Closes #1874

nickclark2016 avatar May 14 '22 06:05 nickclark2016

I'll review this when I have time to sit down and read through the entire toolset. It's a wall of code, so it'll take me a while to get comfortable with it.

nickclark2016 avatar May 14 '22 07:05 nickclark2016

For information, a large part of the code is copied from the gcc toolset. I tried to find an equivalent in the Nvidia compiler for each flag but it's not always possible.

abel0b avatar May 14 '22 07:05 abel0b

Sure, I don't expect equivalents to be there for everything. Do you mind posting a link to where you were referencing for the compiler flags just so I'm looking at the same sources as you when I review?

nickclark2016 avatar May 14 '22 08:05 nickclark2016

Here is the latest available documentation for nvidia compiler : NVIDIA HPC Compilers Reference Manual

abel0b avatar May 14 '22 08:05 abel0b

Should it be an external modules instead?

Jarod42 avatar May 18 '22 13:05 Jarod42

Should it be an external modules instead?

Definitely something worth considering.

nickclark2016 avatar May 18 '22 13:05 nickclark2016

Just poking the discussion on whether this should be an external module or a core module.

nickclark2016 avatar Jun 28 '22 14:06 nickclark2016