premake-core icon indicating copy to clipboard operation
premake-core copied to clipboard

Update shadermodel.md

Open thetyl opened this issue 2 years ago • 4 comments

What does this PR do? Update shadermodel documentation to replace auto-generated text.

Thanks for the contribution! Please provide a concise description of the problem this request solves.

How does this PR change Premake's behavior? Modifies the Premake documentation.

Are there any breaking changes? Will any existing behavior change? No.

Anything else we should know? No.

Add any other context about your changes here.

Did you check all the boxes?

  • [CHECK ] Focus on a single fix or feature; remove any unrelated formatting or code changes
  • [CHECK ] Add unit tests showing fix or feature works; all tests pass
  • [CHECK ] Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • [CHECK ] Follow our coding conventions
  • [CHECK ] Minimize the number of commits
  • [ CHECK] Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

thetyl avatar Mar 24 '22 19:03 thetyl

Is there an example of this shader stuff anywhere? And does it only support HLSL?

tommitytom avatar Aug 04 '22 05:08 tommitytom

Yes it only supports HLSL. There is an example usage included in this change.

thetyl avatar Aug 04 '22 06:08 thetyl

@nickclark2016 Could you please approve this PR?

thetyl avatar Aug 04 '22 06:08 thetyl

Just saw the message, the last several weeks have been hectic for me. Still waiting on you to address that last comment, then I'll go ahead and merge.

nickclark2016 avatar Aug 22 '22 02:08 nickclark2016

@TylerDahl ?

KyrietS avatar Nov 28 '22 19:11 KyrietS

@KyrietS Addressed the final issue for line 39.

thetyl avatar Nov 28 '22 22:11 thetyl

Let's wait for @nickclark2016's approval

KyrietS avatar Nov 29 '22 08:11 KyrietS