premake-core icon indicating copy to clipboard operation
premake-core copied to clipboard

Update shadertype.md

Open thetyl opened this issue 2 years ago • 1 comments

What does this PR do? Update the shadertype documentation to remove auto-generated text and add a description and example.

Thanks for the contribution! Please provide a concise description of the problem this request solves.

How does this PR change Premake's behavior? Modifies the Premake documentation.

Are there any breaking changes? Will any existing behavior change? No.

Anything else we should know? No.

Add any other context about your changes here.

Did you check all the boxes?

  • [CHECK] Focus on a single fix or feature; remove any unrelated formatting or code changes
  • [CHECK ] Add unit tests showing fix or feature works; all tests pass
  • [CHECK ] Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • [CHECK ] Follow our coding conventions
  • [CHECK ] Minimize the number of commits
  • [CHECK ] Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

thetyl avatar Mar 24 '22 16:03 thetyl

Sorry, one last minor thing and I'll leave you alone. Instead of making a new commit, could you just amend the previous?

git reset HEAD~
git add --all
git commit --amend --no-edit

We try to keep the number of commits to a minimum (this should be applied to all your PRs).

nickclark2016 avatar Mar 30 '22 02:03 nickclark2016

@TylerDahl please squash your commits if you want to be listed on git blame (and our website) as an author of this change.

  1. Go to your repo and checkout your branch patch-1: git checkout patch-1
  2. git reset --soft master
  3. git add .
  4. git commit -m "Update shadertype.md"
  5. git push --force

If you don't respond then I'll merge your change using squash method. Also @nickclark2016 is your change request resolved? Do you approve this commit in it's current state?

KyrietS avatar Nov 28 '22 19:11 KyrietS

@KyrietS Just squashed my commits.

thetyl avatar Nov 28 '22 21:11 thetyl

Let's wait for @nickclark2016's approval

KyrietS avatar Nov 29 '22 08:11 KyrietS