xhprof icon indicating copy to clipboard operation
xhprof copied to clipboard

check on file exist for xhprof_urlSimilartor_include

Open StVolodymyr opened this issue 12 years ago • 2 comments

StVolodymyr avatar Jun 18 '13 06:06 StVolodymyr

So the goal here is to avoid having a fatal error if there's a specified value, but the path fails?

I'm quite torn. I'd really rather things failed loudly, rather than silently (imagine specifying the wrong path, expecting it to have worked, and getting nothing). But non-fatal errors are also super.

thoughts?

preinheimer avatar Jun 20 '13 13:06 preinheimer

i don't want get fatal error when file not exists, because it crash whole application. though, you're right what silently ignore this error is not good. I think what warning trigger_error("File urlSimilartor {$similartorinclude} not exist", E_USER_WARNING) is better

StVolodymyr avatar Jun 20 '13 13:06 StVolodymyr