rattler-build icon indicating copy to clipboard operation
rattler-build copied to clipboard

Top level skip gets overriden in outputs

Open isuruf opened this issue 3 months ago • 2 comments

For example, the following recipe should be skipped in linux, but it is not

context:
  version: "1.0.0"

recipe:
  name: "foo"
  version: ${{ version }}

build:
  skip: linux

outputs:
  - package:
      name: a
    build:
      skip: osx

  - package:
      name: b
    build:
      skip: win

isuruf avatar Oct 06 '25 21:10 isuruf

I guess this is probably an issue with our merging logic, indeed.

I do wonder if it's better to merge the list of skip conditions or just replace the whole key/value (which is the current behavior). I see that there is merit to inheriting the skip conditions but it also complicates the logic a bit (and I also am not sure if all lists should be merged).

wolfv avatar Oct 07 '25 07:10 wolfv

Yeah, probably an issue with merging logic. I think of a top-level skip as a directive for the whole recipe to be skipped not as a default for outputs to override later if needed.

isuruf avatar Oct 07 '25 17:10 isuruf