rattler-build icon indicating copy to clipboard operation
rattler-build copied to clipboard

refactor: simplify buffer reader usage and enhance zip extraction logic

Open zelosleone opened this issue 5 months ago • 1 comments

this will solve the zed stock problem @baszalmstra is facing the recipe i used with test is the same one https://github.com/baszalmstra/zed-feedstock/blob/be25438c26f8f44a70566f6ea992367c04c55580/recipe/recipe.yaml

the problem seems to be the zip crate's bug itself, which fails to extract certain zip files on windows and sometimes even fails to extract them correctly https://github.com/zip-rs/zip2/issues?q=is%3Aissue%20state%3Aopen%20windows (seems like a recent issue but no comments so far on any of the bugs, which i think pretty critical) so instead with the same logic we are extracting them manually and it works correctly now

zelosleone avatar Jul 22 '25 15:07 zelosleone

It is still unclear to me what this solves? can you maybe explain the exact error this solves? You only link to an issue listing and the recipe you reference fails in a cargo invocation, not in rattler-build.

baszalmstra avatar Jul 30 '25 15:07 baszalmstra