rattler-build icon indicating copy to clipboard operation
rattler-build copied to clipboard

fix: library mapping in linking checks

Open zelosleone opened this issue 7 months ago • 3 comments

closes https://github.com/prefix-dev/rattler-build/issues/1684

now we will:

  • populate library mappings after package installation
  • hopefully do more accurate detection of system vs conda-provided libraries but i will wait for wolf's opinion on this
  • ensure cache dependencies are also properly checked

since library mapping is also improved, now we will be able to track files provided by each package as well!

zelosleone avatar Jun 11 '25 21:06 zelosleone

IMO this is too much change in a single PR.

What I would be fine with is if we change the overlinking checks to not rely on the host prefix files but instead combine the packages from host prefix & cache host prefix and determine the shared libraries based on the paths.json file from the different packages (without touching the actual filesystem).

wolfv avatar Jun 17 '25 15:06 wolfv

I am thinking the best thing would be to add a new file in the cache folder that would capture these mappings (or let the first post-processing step create this file).

We could make a new file that would be called something like "post-process-mappings.json" and place it in the $CACHE_FOLDER/post-process-mappings.json.

Then, every process using the cache contents could also (re-)use the post process mapping file.

Would that make sense and perhaps simplify things?

wolfv avatar Jun 24 '25 10:06 wolfv

Looking forward to this one; thanks for your work here!

yeetfield avatar Aug 21 '25 19:08 yeetfield