rattler-build icon indicating copy to clipboard operation
rattler-build copied to clipboard

make filter works with tarball/zip source

Open trim21 opened this issue 7 months ago • 4 comments

HI, I'm trying to use a tarball including a symlink on windows, and it's not necessary for building conda package.

Is it possible that make source.filter.exlude work with tarball so I can exclude them?

trim21 avatar May 17 '25 08:05 trim21

I think it would be even better to fix our tarball extraction code to deal with symlinks on Windows (either ignore them, extract them, or copy the file).
Would be good to re-visit if the tar crate supports this better now.

wolfv avatar May 19 '25 09:05 wolfv

if we are talking about symlink, it also break git as source, it can't get sha from ref if that ref contains symlink...

trim21 avatar May 19 '25 09:05 trim21

as for tarball/zip, I think it would be more safe to add a option to allow "copy the file", in case there are some build script that change source and read from dest of symlink.

extract them doesn't look a allways-work option because in some case it fail because it doesn't have sudo permission and can't create link.

trim21 avatar May 19 '25 09:05 trim21

I end up using git clone with --config in build script, another option for this may be allowing user to pass config in git source

trim21 avatar May 19 '25 18:05 trim21