pixi icon indicating copy to clipboard operation
pixi copied to clipboard

Modifying editable python packages will still call a rebuild using `pixi install`

Open ruben-arts opened this issue 8 months ago • 1 comments

Checks

  • [x] I have checked that this issue has not already been reported.

  • [x] I have confirmed this bug exists on the latest version of pixi, using pixi --version.

Reproducible example

Changing the https://github.com/ruben-arts/pycon-de-2025/blob/e89430183c06f15d6afc8a2a2f8501a1a073cca1/src/python_bindings/src/python_bindings/person.py file in this workspace will always rebuild the package even though it should be an editable install.

gh repo clone ruben-arts/pycon-de-2025
cd pycon-de-2025
pixi i
# MODIFY THE /src/python_bindings/person.py
pixi i 
# reinstalls but shouldn't

Issue description

An editable install should never be build unless the manifest is modified or reinstall is called. The editable part works when you go into a pixi shell and run the file with python after modifing it.

Expected behavior

Leave the package alone as it's editable

ruben-arts avatar Apr 25 '25 08:04 ruben-arts

I think that line is to blame: https://github.com/prefix-dev/pixi-build-backends/blob/cf6388adfff1d3abf6ab9b06f9e37238ba5e4f2a/crates/pixi-build-python/src/protocol.rs#L352-L353

I think we should return a different glob without .py files in editable mode

Hofer-Julian avatar Apr 25 '25 08:04 Hofer-Julian

Possibly fixed by: https://github.com/prefix-dev/pixi-build-backends/pull/136

wolfv avatar May 02 '25 17:05 wolfv

We should modify the globs indeed :)

tdejager avatar May 19 '25 08:05 tdejager

This is indeed fixed by https://github.com/prefix-dev/pixi-build-backends/pull/136. I cannot reproduce this anymore.

baszalmstra avatar May 19 '25 11:05 baszalmstra

That could still benefit from a regression test though :)

On Mon, 19 May 2025 at 13:18, Bas Zalmstra @.***> wrote:

Closed #3684 https://github.com/prefix-dev/pixi/issues/3684 as completed.

— Reply to this email directly, view it on GitHub https://github.com/prefix-dev/pixi/issues/3684#event-17712985291, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADF4XXUDF56JHMNXFZRERL27G4ZPAVCNFSM6AAAAAB327UDY2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJXG4YTEOJYGUZDSMI . You are receiving this because you were assigned.Message ID: @.***>

tdejager avatar May 19 '25 17:05 tdejager