pixi icon indicating copy to clipboard operation
pixi copied to clipboard

Published 20 hours ago • verified publisher icon prefix-dev

fix: Use the right channels when upgrading global packages

Open olivier-lacroix opened this issue 9 months ago • 4 comments

Fixes https://github.com/prefix-dev/pixi/issues/1318

olivier-lacroix avatar May 06 '24 12:05 olivier-lacroix

I actually think we should store the initial request in the environment - requested platform and channel.

In the future we migth store more (like inject'ed packages etc.).

wolfv avatar May 06 '24 13:05 wolfv

@wolfv is there a specific method to do that?

olivier-lacroix avatar May 06 '24 13:05 olivier-lacroix

Not yet I believe. My idea was to store a little JSON file in the conda-meta/ folder (or another format), that would contain this meta information. (it should not have a .json file ending though because we currently try to parse all files in that folder that end wtih json as PrefixRecords).

wolfv avatar May 06 '24 15:05 wolfv

Ok @wolfv . Let me see about that.

olivier-lacroix avatar May 07 '24 07:05 olivier-lacroix

@wolfv , I think the question of storing data in a file for global packages is broader than this PR. So I prefer to not get into that rabbit hole here.

@pavelzw any chance you could check this indeed resolves #1318 ?

I made a number of steps parallel. It does not seem to have a meaningful impact in terms of speed, so happy to either leave it as is, or revert to a simpler, non-parallel upgrade function.

olivier-lacroix avatar May 19 '24 05:05 olivier-lacroix

Just checked, #1318 was already fixed by #1324 and works with pixi 0.21.0 already 😅 But I also checked with this PR and it still works with this PR as well.

pavelzw avatar May 19 '24 09:05 pavelzw