plotly-resampler
plotly-resampler copied to clipboard
:bug: parse object arrays for hf_x
This PR does the following;
- Parse
hf_x
to numeric or datetime ifhf_x
is an array of dtype object.- should fix #115 -> object arrays were not handled as before + we've now add plotly-like support for multiple timezones in same x-arrray
- should fix #120
-> issue stemmed from object array of datetimes being used, parsing this with
pd.to_datetime
solves this
- Update poetry install in CI-CD (see #117)
- Extend tests & validate whether this is inline with plotly behavior
Note that this parsing removes any time zone information when necessary (i.e., when there are multiple timezones in the same x-data);
- [x] check if this is consistent with plotly behavior
- [ ] optimize speed when removing timezone info (currently this is a list map..)
Codecov Report
Merging #116 (5efd2e3) into main (71b4efe) will increase coverage by
0.03%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 97.46% 97.49% +0.03%
==========================================
Files 11 11
Lines 867 878 +11
==========================================
+ Hits 845 856 +11
Misses 22 22
Impacted Files | Coverage Δ | |
---|---|---|
plotly_resampler/aggregation/__init__.py | 100.00% <100.00%> (ø) |
|
...ler/figure_resampler/figure_resampler_interface.py | 99.73% <100.00%> (+<0.01%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Have you found any time to look into my remarks @jvdd?
LGTM!
Also tested the basic example notebook and the pandas
plotting backend datetime issue is not yet resolved 😢
Squash merged this into main! Do we create a new release?