merge-img icon indicating copy to clipboard operation
merge-img copied to clipboard

Published 20 hours ago • verified publisher icon preco21

feat: update jimp version

Open sj82516 opened this issue 4 years ago • 7 comments

  1. Update Jimp package version
  2. Add package-lock.json
  3. Fix eslint issue

I passed all test.
This should be solved multiple issue

  1. https://github.com/preco21/merge-img/issues/15 npm audit would only report low priority issue.
  2. https://github.com/preco21/merge-img/issues/6

sj82516 avatar Aug 26 '20 21:08 sj82516

Please merge it asap

mathias22osterhagen22 avatar Sep 03 '20 14:09 mathias22osterhagen22

Hi, sorry for the late response.

I'm not quite sure if we can just upgrade it and go since I haven't been worked on this module for a long time.

preco21 avatar Sep 03 '20 18:09 preco21

@preco21 Do you need more test case to approve the PR ? Maybe you could mention some test case scenario and I would help to write test cases.

yuanchieh-cheng avatar Sep 07 '20 08:09 yuanchieh-cheng

👍

clementlecorre avatar Oct 07 '20 08:10 clementlecorre

@preco21 & @alirezamirian: First of all thanks a lot for your software. Do you have the chance in approving this PR as it will fix a high severity bug in a subdependency of jimp-dependency?

mfranzke avatar Feb 05 '21 06:02 mfranzke

@preco21 Why this PR can not be just merged ???

senpl avatar May 07 '21 09:05 senpl

For this tired of waiting I created copy https://www.npmjs.com/package/merge-img-vwv only downside is that it has to be merge-img-vwv instead of merge-img . I just took this PR update lib and description. It works on my cases, if something is not work after lib update PR are welcomed.

senpl avatar May 10 '21 08:05 senpl

Hi, my apologies for the late response. I missed the email notification and now I've just realized that this PR is still open.

I'm merging this PR anyway even if it's no longer relevant.

Please note that this project is no longer maintained.

I recommend you to use alternatives or pick up the simple algorithm from the library source then combine with the latest modules. Or, feel free to fork it.

Thanks.

preco21 avatar Feb 01 '24 04:02 preco21