tutorials icon indicating copy to clipboard operation
tutorials copied to clipboard

Add solid fake for perpendicular flap tutorial

Open NiklasVin opened this issue 1 year ago • 4 comments

I added a solid fake implemented in Python to the perpendicular flap tutorial, similar to the already existing fluid-fake.

NiklasVin avatar Jun 17 '24 19:06 NiklasVin

Is this ready for review? Don't forget to add it into the README of the tutorial. I can generate some of the plots when reviewing.

I will fix the markdownlint, it is failing also elsewhere.

MakisH avatar Jun 24 '24 08:06 MakisH

@NiklasVin please rebase/merge from develop, the markdownlint issue is now fixed.

MakisH avatar Jun 27 '24 06:06 MakisH

Is this ready for review? Don't forget to add it into the README of the tutorial. I can generate some of the plots when reviewing.

I will fix the markdownlint, it is failing also elsewhere.

Yes, now this should be ready for review.

NiklasVin avatar Jun 28 '24 22:06 NiklasVin

@NiklasVin can you please enable edits by maintainers? It's a checkbox on the right.

MakisH avatar Jul 02 '24 07:07 MakisH