su2-adapter icon indicating copy to clipboard operation
su2-adapter copied to clipboard

Published 20 hours ago • verified publisher icon precice

Maintainer needed (experience with SU2)

Open MakisH opened this issue 4 years ago • 5 comments

Dear preCICE community, dear SU2 community,

as you see, this repository is currently not actively maintained, but it is also not abandoned. As the preCICE developers have limited experience with SU2, we would very happily accept contributions to keep this project up-to-date.

If you have experience with SU2, maintaining the adapter (e.g. updating for new SU2 versions, commenting on issues, reviewing pull requests) would be quite easy and you would have all the help you need from our side. Due to the low demand for this adapter and the low frequency of SU2 releases, the time demand would be also low and, of course, on your own pace. Any help appreciated, for as long as you like.

Contribute to a quickly growing free/open-source project, be part of an enthusiastic community. Simply comment here if you can help. :hugs:

MakisH avatar May 03 '20 09:05 MakisH

@MakisH I will have a look and evaluate the code a bit. I will let you know accordingly if I can be helpful. Thanks!

NAnand-TUD avatar Feb 22 '22 13:02 NAnand-TUD

@MakisH I am following up on our conversation from Gitter. I will go through the new releases of SU2 and probably some of the tutorials you have for other adapters. Let me know if you would like to meet sometime. I am looking to develop or perhaps extend Rusch's adapters to newer versions of SU2 and run some large-scale test cases over a cluster with detailed profiling studies specific to SU2, precice and probably some FEA solvers.

Pranjan2 avatar Feb 23 '22 11:02 Pranjan2

@MakisH how would you like me to share the adapter files ? I have started working on them and would like to regularly push to a repo/branch and have it ready for the moderators to review once done.

Pranjan2 avatar Mar 23 '22 17:03 Pranjan2

Easiest is probably if you push the changes to a branch in your fork of this repo and then open a PR. Let us know if this isn't clear. Happy to help.

uekerman avatar Apr 02 '22 14:04 uekerman

@Pranjan2 sorry for only reacting now. As said already, you can just fork and open pull requests.

Best would be to submit multiple small pull requests from your fork to the develop branch of the adapter. It is important that the pull requests are small, to be able to review them. It is also important that you don't commit to your master branch, so that you can easily incorporate the changes from the reviews.

Since multiple people have expressed interest to help, keeping the pull requests small and frequent will be very helpful.

MakisH avatar Apr 06 '22 20:04 MakisH