python-bindings icon indicating copy to clipboard operation
python-bindings copied to clipboard

Including Participant.hpp instead of precice.hpp - By design or outdated?

Open MakisH opened this issue 1 year ago • 1 comments

https://github.com/precice/python-bindings/blob/536d385a0fdb77656011f45cf32ab9b3be16de3b/cyprecice/Participant.pxd#L6

The precice/Participant.hpp is the renamed precice/SolverInterface.hpp. However, we now also have precice/precice.hpp, which is meant to be the central header to include. This currently contains also Version.h, span.hpp, and could in the future contain more (or less).

This is not a problem, especially since it works at the moment, but it sticks out in the architecture picture. Changing it should have no functional effect anywhere.

Bindings

MakisH avatar Feb 08 '24 21:02 MakisH

This is outdated and something I forgot to update before releasing the bindings. I have opened a draft pull request to do this: https://github.com/precice/python-bindings/pull/193

IshaanDesai avatar Feb 09 '24 06:02 IshaanDesai