openfoam-adapter icon indicating copy to clipboard operation
openfoam-adapter copied to clipboard

Published 20 hours ago • verified publisher icon precice

CHT: split code for preCICE adapter and openfoam

Open TEFEdotCC opened this issue 4 years ago • 7 comments

Based on #144 .

  • [x] Move wall treatment code to boundary condition.
  • [x] Revision of the CHT module so that it is independent of fluid dynamics.
  • [x] All relevant solver are supported by the CHT module.
  • [x] Radiation support implemented.
  • [x] Introduce the Core directory for the adapter code files.
  • [x] Usage of openfoam way to provide missing informations (0 directory, usage of fields).
  • [x] Revision of CHT module tutorial flow over plate.
  • [x] Add water heater example.

The changes of #144 based on better coding are not applyed to that pull request. (raw pointer, Foam types, ...)

TEFEdotCC avatar Jan 30 '21 12:01 TEFEdotCC

Test build for

  • openfoam.com Dockerfile https://github.com/TEFEdotCC/Containered-OpenFOAM.com
  • openfoam.org Dockerfile https://github.com/TEFEdotCC/Containered-OpenFOAM.org

TEFEdotCC avatar Jan 30 '21 13:01 TEFEdotCC

First compilation check due to #128 list

OpenFOAM.org

  • [ ] OpenFOAM 4.0, 4.1, 4.x , skipped Official versions on github (branch "master" and tags "version-4.0" / "version-4.1") leads into build issues.
  • [x] OpenFOAM 5.x
  • [x] OpenFOAM 6
  • [x] OpenFOAM 7
  • [x] OpenFOAM 8
  • [x] OpenFOAM dev (8917f4b51f974f3b38a2d4cd328b03262c34c15b, 2021-02-06)

OpenFOAM.com

  • [ ] OpenFOAM v1606 and afore , skipped OpenFOAM build issue with gitlab sources.
  • [ ] OpenFOAM v1612 , skipped OpenFOAM build issue with gitlab sources.
  • [ ] OpenFOAM v1706 , skipped OpenFOAM build issue with gitlab sources.
  • [x] OpenFOAM v1712
  • [x] OpenFOAM v1806
  • [x] OpenFOAM v1812
  • [x] OpenFOAM v1906
  • [x] OpenFOAM v1912
  • [x] OpenFOAM v2006
  • [x] OpenFOAM v2012
  • [x] OpenFOAM develop (13152510b3a05bb65f01d3025ca45f005ecc2fb0, 2021-02-07)

TEFEdotCC avatar Feb 08 '21 08:02 TEFEdotCC

For version handling, I decided on the idea two of #32 (pre-processor commands).

  • The method allows both vendors to be handled.
  • The differences between the OpenFOAM versions / vendors can be seen directly in the code.
  • As long as there is no major design change from an OpenFOAM vendor, using pre-processor commands is a good way to go.
  • Support of OpenFOAM <5.x are irrelevant from my point of view, since the github sources do not build without manual intervention. (Fedora version 32)

The idea in #128 is very complex and work-intensive for the implementation of new features for all versions (the developer has to look up the information about all variants).

  • [ ] Support for all OpenFOAM versions is not sustainable in the long term without great effort. A roadmap (from when a version is supported) should be considered.

TEFEdotCC avatar Feb 08 '21 08:02 TEFEdotCC

external todo's:

  • [ ] Check/update tutorial scripts (especially FSI tutorials)
  • [ ] Update wiki page Notes on OpenFOAM
  • [ ] Update system tests

TEFEdotCC avatar Feb 08 '21 08:02 TEFEdotCC

#129 / #130 included

TEFEdotCC avatar Feb 08 '21 08:02 TEFEdotCC

This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/different-dimensions-for-dimensions-issue/535/8

precice-bot avatar Apr 07 '21 18:04 precice-bot

This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/issues-on-precice-for-cht-problem-icoreactingmultiphaseinterfoam-and-laplacianfoam/679/12

precice-bot avatar Aug 06 '21 21:08 precice-bot