calculix-adapter icon indicating copy to clipboard operation
calculix-adapter copied to clipboard

Inconsistent lookup for read/write data in CHT and FSI

Open MakisH opened this issue 1 year ago • 0 comments

For temperature and heat flux, we are checking whether the field name is exactly matched in the config:

https://github.com/precice/calculix-adapter/blob/4496e8f160ec121481653baf44ec032813409ac6/adapter/PreciceInterface.c#L624

For other fields, we are checking whether the field name just starts with this prefix (similar behavior as in the OpenFOAM adapter), sometimes with a trailing -, sometimes without:

https://github.com/precice/calculix-adapter/blob/4496e8f160ec121481653baf44ec032813409ac6/adapter/PreciceInterface.c#L37

https://github.com/precice/calculix-adapter/blob/4496e8f160ec121481653baf44ec032813409ac6/adapter/PreciceInterface.c#L654

Additionally, data names are hard-coded for preCICE:

https://github.com/precice/calculix-adapter/blob/4496e8f160ec121481653baf44ec032813409ac6/adapter/PreciceInterface.c#L628

Finally, this error message is rather confusing:

https://github.com/precice/calculix-adapter/blob/4496e8f160ec121481653baf44ec032813409ac6/adapter/PreciceInterface.c#L662

"Does not exist" made me think that I still needed to specify it somewhere. However, it just means that the adapter does not know how to handle it.

MakisH avatar Oct 24 '22 18:10 MakisH