prebid.github.io icon indicating copy to clipboard operation
prebid.github.io copied to clipboard

Rename imds adapter to advertising to reflect ownership change to advertising.com

Open pratik-chavan-advertising-dot-com opened this issue 9 months ago • 3 comments

🏷 Type of documentation

  • [X] new bid adapter
  • [X] update bid adapter
  • [ ] new feature
  • [X] text edit only (wording, typos)
  • [ ] bugfix (code examples)
  • [ ] new examples

📋 Checklist

  • [X] Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • [X] For new adapters check submitting your adapter docs

https://github.com/prebid/Prebid.js/pull/12878 https://github.com/prebid/prebid-server/pull/4258

Deploy Preview for prebid-docs-preview ready!

Name Link
Latest commit cdccdba7ff2042efe388da6db8df44361d69a140
Latest deploy log https://app.netlify.com/projects/prebid-docs-preview/deploys/6835e5a7896d980008f54ba4
Deploy Preview https://deploy-preview-5943--prebid-docs-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Mar 12 '25 20:03 netlify[bot]

The rename on the Prebid.js side was premature, IMO. The ability for publishers to build your imds adapter into their package using the download page is now broken.

Here's what you need to do to fix:

  • Add aliasCode: advertising to the metadata for imds.md. It might help to add a note like the one in synacormedia.md
  • Add aliasCode: advertising to the metadata for synacormedia.md and update the note in that file.

All we did was merge the change into the unreleased 10 branch; it isnt in master

patmmccann avatar Mar 31 '25 19:03 patmmccann

All we did was merge the change into the unreleased 10 branch; it isnt in master

Cool.

I still recommend doing these things:

  • Add aliasCode: advertising to the metadata for imds.md. It might help to add a note like the one in synacormedia.md
  • Add aliasCode: advertising to the metadata for synacormedia.md and update the note in that file.

But we won't merge that docs update until PBJS 10.0.

bretg avatar Mar 31 '25 20:03 bretg

Hi @pratik-chavan-advertising-dot-com

Can you update the docs according to the review comments from Bret?

muuki88 avatar May 15 '25 13:05 muuki88

Hi @muuki88 @patmmccann I've updated the PR with the requested changes. Please let me know if everything looks good now.

Also, do you have an estimate for the pbjs version 10.0 launch timeline?