prebid.github.io icon indicating copy to clipboard operation
prebid.github.io copied to clipboard

Work in progress consentmanager migration

Open muuki88 opened this issue 1 year ago • 10 comments

Migration from OneTrust to consentmanager.net for cookie consent.

#5149

muuki88 avatar Feb 11 '24 10:02 muuki88

Deploy Preview for prebid-docs-preview ready!

Name Link
Latest commit cceaaa8320fdeede2326efb66ef75ba03cee5883
Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/66466e492c86c20008bf7806
Deploy Preview https://deploy-preview-5152--prebid-docs-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 11 '24 10:02 netlify[bot]

Cookies previously defined in OneTrust

image

image

muuki88 avatar Mar 12 '24 16:03 muuki88

https://docs.prebid.org/prebid-video/video-integrating-solo.html keep the linked ones here and remove the rest.

muuki88 avatar Apr 09 '24 14:04 muuki88

Checking the video examples and it looks good

  • https://deploy-preview-5152--prebid-docs-preview.netlify.app/dev-docs/examples/instream-banner-mix
  • https://deploy-preview-5152--prebid-docs-preview.netlify.app/examples/video/instream/videojs/pb-ve-videojs
  • https://deploy-preview-5152--prebid-docs-preview.netlify.app/examples/video/instream/jwplayer/pb-ve-jwplayer-hosted

muuki88 avatar Apr 18 '24 21:04 muuki88

@muuki88 - looked things over. The remaining questions are about the video examples.

Neither of these work for me locally

  • pb-ve-jwplayer-platform.html
  • pb-ve-jwplayer-hosted.html

This shows the player regardless of cookie settings

  • pb-ve-videojs.html

This page is titled oddly and doesn’t make sense where it is in the nav bar

  • /prebid-video/video-integrating-solo.html

The Vimeo videos aren’t affected. Not following _includes/vimeo-iframe.html

bretg avatar May 02 '24 15:05 bretg

Thanks @bretg for taking a look. most of the examples did not work for me neither, but as far as I could tell, consent was not the issue.

Regarding the naming, I'll take a look when I'm back from London.

muuki88 avatar May 02 '24 15:05 muuki88

Some of these problems (e.g. the odd title) exist in the current site, so we can fix that in a separate PR.

The video examples like https://docs.prebid.org/examples/video/instream/jwplayer/pb-ve-jwplayer-platform.html don't work currently either. Maybe we should just merge this PR and work with the video team to repair the examples -- maybe refactoring them to not require actual bids at the same time?

bretg avatar May 02 '24 15:05 bretg

What I can see is not working is the JW player that is missing a licence key. From a technical perspective the pipes work :grimacing:

https://deploy-preview-5152--prebid-docs-preview.netlify.app/examples/video/instream/jwplayer/pb-ve-jwplayer-hosted

image

Maybe we should just merge this PR and work with the video team to repair the examples -- maybe refactoring them to not require actual bids at the same time?

Yes. I'm all for that. I would phrase it that the examples are less broken, because the consent stuff at least works now.

muuki88 avatar May 10 '24 10:05 muuki88

This shows the player regardless of cookie settings

  • pb-ve-videojs.html

And it should, because it's a native HTML element :tada:

      <video
        id="vid1"
        class="video-js vjs-default-skin vjs-big-play-centered"
        controls
        data-setup="{}"
        width="640"
        height="480"
      >
        <source src="https://vjs.zencdn.net/v/oceans.mp4" type="video/mp4" />
        <source src="https://vjs.zencdn.net/v/oceans.webm" type="video/webm" />
        <source src="https://vjs.zencdn.net/v/oceans.ogv" type="video/ogg" />
      </video>

There's no additional player loaded and no ads if you don't load it. I could however hide it behind consent to make it clearer.

muuki88 avatar May 10 '24 10:05 muuki88

This page is titled oddly and doesn’t make sense where it is in the nav bar

  • /prebid-video/video-integrating-solo.html

image

The naming is indeed a bit odd. The place in the sidebar however is correct. I'll open another issue to tackle this. Changing the URL structure is IMHO out of scope here.

The Vimeo videos aren’t affected. Not following _includes/vimeo-iframe.html

I don't quite get this :sweat_smile: Is this a question, request or just a statement?

muuki88 avatar May 10 '24 10:05 muuki88

@bretg . It is done :tada: . All vimeo videos are now also behind the consent check

muuki88 avatar May 16 '24 20:05 muuki88

merging

bretg avatar May 17 '24 20:05 bretg