New Adapter: Nuba
Type of change
-
[ ] Bugfix
-
[ ] Feature
-
[x] New bidder adapter
-
[ ] Updated bidder adapter
-
[ ] Code style update (formatting, local variables)
-
[ ] Refactoring (no functional changes, no api changes)
-
[ ] Build related changes
-
[ ] CI related changes
-
[ ] Does this change affect user-facing APIs or examples documented on http://prebid.org?
-
[ ] Other
Description of change
Other information
doc MR: https://github.com/prebid/prebid.github.io/pull/6295
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, b9a4ba663b00a32992dd47880d7b6e4e44805633
nuba
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:30: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:37: MakeRequests 85.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:84: makeRequest 85.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:102: MakeBids 100.0%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:138: getMediaTypeForImp 100.0%
total: (statements) 92.2%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 6c9d9f22d99200e5f37a7045ba8250c3e2134a74
nuba
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:30: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:37: MakeRequests 85.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:84: makeRequest 85.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:102: MakeBids 95.2%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:143: getMediaTypeForImp 66.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:162: getMediaTypeForBid 100.0%
total: (statements) 87.5%
Hi @nuba-io, is this a white label solution? This looks very similar to the Compass adapter.
Hi @bsardo, Yes, is a white label solution. It may look similar to Compass, but it's a separate solution.
Hi, @bsardo @jney @minaguib @dlackty ) Do you have any other comments on PR?
@nuba-io thanks for the response. Can you elaborate on why you're calling it a white label but also a separate solution? Prebid Server has strict guidelines that if an adapter is a white label, the aliasing feature should be used instead of copying an adapter. This significantly reduces review and maintenance time as it cuts the lines of code from 1k+ to ~20.
Hi, @bsardo Thanks for raising this point — it’s a valid concern. We’ve updated the PR to fully align with the white-label guidelines you mentioned. The implementation now uses the aliasing approach instead of duplicating the adapter, which keeps the code minimal and reduces the review and maintenance overhead.
If there’s anything else we should refine, happy to adjust.