prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

New Adapter: Nuba

Open nuba-io opened this issue 2 months ago • 4 comments

Type of change

  • [ ] Bugfix

  • [ ] Feature

  • [x] New bidder adapter

  • [ ] Updated bidder adapter

  • [ ] Code style update (formatting, local variables)

  • [ ] Refactoring (no functional changes, no api changes)

  • [ ] Build related changes

  • [ ] CI related changes

  • [ ] Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • [ ] Other

Description of change

Other information

doc MR: https://github.com/prebid/prebid.github.io/pull/6295

nuba-io avatar Oct 10 '25 11:10 nuba-io

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b9a4ba663b00a32992dd47880d7b6e4e44805633

nuba

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:30:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:37:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:84:	makeRequest		85.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:102:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:138:	getMediaTypeForImp	100.0%
total:								(statements)		92.2%

github-actions[bot] avatar Oct 10 '25 11:10 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6c9d9f22d99200e5f37a7045ba8250c3e2134a74

nuba

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:30:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:37:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:84:	makeRequest		85.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:102:	MakeBids		95.2%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:143:	getMediaTypeForImp	66.7%
github.com/prebid/prebid-server/v3/adapters/nuba/nuba.go:162:	getMediaTypeForBid	100.0%
total:								(statements)		87.5%

github-actions[bot] avatar Oct 14 '25 07:10 github-actions[bot]

Hi @nuba-io, is this a white label solution? This looks very similar to the Compass adapter.

bsardo avatar Oct 28 '25 16:10 bsardo

Hi @bsardo, Yes, is a white label solution. It may look similar to Compass, but it's a separate solution.

nuba-io avatar Nov 04 '25 08:11 nuba-io

Hi, @bsardo @jney @minaguib @dlackty ) Do you have any other comments on PR?

nuba-io avatar Nov 14 '25 10:11 nuba-io

@nuba-io thanks for the response. Can you elaborate on why you're calling it a white label but also a separate solution? Prebid Server has strict guidelines that if an adapter is a white label, the aliasing feature should be used instead of copying an adapter. This significantly reduces review and maintenance time as it cuts the lines of code from 1k+ to ~20.

bsardo avatar Nov 20 '25 15:11 bsardo

Hi, @bsardo Thanks for raising this point — it’s a valid concern. We’ve updated the PR to fully align with the white-label guidelines you mentioned. The implementation now uses the aliasing approach instead of duplicating the adapter, which keeps the code minimal and reduces the review and maintenance overhead.

If there’s anything else we should refine, happy to adjust.

nuba-io avatar Nov 21 '25 13:11 nuba-io