prebid-server
prebid-server copied to clipboard
New Adapter: Waardex
https://github.com/prebid/prebid.github.io/pull/6290
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 2d0320bf87a122fc44ea033e8814082e1b5bd705
waardex
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/waardex/waardex.go:24: MakeRequests 70.0%
github.com/prebid/prebid-server/v3/adapters/waardex/waardex.go:56: getImpressionsInfo 73.3%
github.com/prebid/prebid-server/v3/adapters/waardex/waardex.go:78: validateImpression 66.7%
github.com/prebid/prebid-server/v3/adapters/waardex/waardex.go:86: dispatchImpressions 100.0%
github.com/prebid/prebid-server/v3/adapters/waardex/waardex.go:106: isMultiFormatImp 80.0%
github.com/prebid/prebid-server/v3/adapters/waardex/waardex.go:123: splitMultiFormatImp 100.0%
github.com/prebid/prebid-server/v3/adapters/waardex/waardex.go:142: getImpressionExt 71.4%
github.com/prebid/prebid-server/v3/adapters/waardex/waardex.go:158: buildAdapterRequest 83.3%
github.com/prebid/prebid-server/v3/adapters/waardex/waardex.go:183: createBidRequest 100.0%
github.com/prebid/prebid-server/v3/adapters/waardex/waardex.go:202: buildEndpointURL 100.0%
github.com/prebid/prebid-server/v3/adapters/waardex/waardex.go:208: MakeBids 73.7%
github.com/prebid/prebid-server/v3/adapters/waardex/waardex.go:248: getMediaTypeForBid 50.0%
github.com/prebid/prebid-server/v3/adapters/waardex/waardex.go:265: newBadInputError 0.0%
github.com/prebid/prebid-server/v3/adapters/waardex/waardex.go:271: newBadServerResponseError 0.0%
github.com/prebid/prebid-server/v3/adapters/waardex/waardex.go:278: Builder 100.0%
total: (statements) 80.6%
You have mandatory adapter parameters that also need to be tested.
From the documentation: Bidder Parameter Tests
The bidder parameter JSON Schema files are considered a form of code and must be tested.
Create a file with the path adapters/{bidder}/params_test.go
Example of valid parameters for validation:
var validParams = []json.RawMessage{
json.RawMessage(`{"zoneId": 101}`),
}
Example of invalid parameters for validation:
var invalidTypeParams = []json.RawMessage{
json.RawMessage(`{"zoneId": "101"}`), // String instead of integer
json.RawMessage(`{"zoneId": 1.5}`), // Float instead of integer
json.RawMessage(`{"zoneId": true}`), // Boolean instead of integer
json.RawMessage(`{"zoneId": []}`), // Array instead of integer
json.RawMessage(`{"zoneId": {}}`), // Object instead of integer
}