prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard
verified publisher icon prebid

New Adapter: RevX

Open nikithacode opened this issue 7 months ago • 18 comments

nikithacode avatar May 09 '25 06:05 nikithacode

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5645a812038893ff491344fea6b5e1e87ec7ae01

revx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/revx/revx.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:28:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:80:	MakeBids		81.8%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:132:	getMediaTypeForImp	85.7%
total:								(statements)		84.3%

github-actions[bot] avatar May 09 '25 06:05 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 690b4dc6bed1f1c8c58435a84b2b28c4523f25dc

revx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/revx/revx.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:28:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:80:	MakeBids		81.8%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:132:	getMediaTypeForImp	85.7%
total:								(statements)		84.3%

github-actions[bot] avatar May 09 '25 06:05 github-actions[bot]

Hi @bsardo could you please review this

nikithacode avatar May 29 '25 05:05 nikithacode

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 92ee93d1b32655b30086ace738710c78326187f0

revx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/revx/revx.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:28:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:80:	MakeBids		81.8%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:132:	getMediaTypeForImp	85.7%
total:								(statements)		84.3%

github-actions[bot] avatar Jun 10 '25 13:06 github-actions[bot]

@pm-jaydeep-mohite can you please review?

bsardo avatar Jun 13 '25 17:06 bsardo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 55b484eb8743c6d24edeb30dac56d2218dc29e7a

revx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/revx/revx.go:21:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:28:	MakeRequests				79.2%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:80:	MakeBids				81.8%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:125:	getMediaTypeForImp			100.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:141:	CheckResponseStatusCodeForErrors	100.0%
total:								(statements)				84.2%

github-actions[bot] avatar Jul 03 '25 07:07 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, a0caa1aab104ce376c7c5dea0890103429bb0248

revx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/revx/revx.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:28:	MakeRequests		85.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:73:	MakeBids		81.8%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:118:	getMediaTypeForImp	100.0%
total:								(statements)		85.4%

github-actions[bot] avatar Jul 10 '25 05:07 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7fcf91d32c78e6a814b2171de9261cf8a1cfa159

revx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/revx/revx.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:28:	MakeRequests		85.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:73:	MakeBids		83.3%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:127:	getMediaTypeForImp	100.0%
total:								(statements)		86.0%

github-actions[bot] avatar Jul 15 '25 12:07 github-actions[bot]

Hi @pm-jaydeep-mohite could you please review the updated changes

nikithacode avatar Jul 31 '25 11:07 nikithacode

hi @pm-jaydeep-mohite @bsardo could you please review the updated code changes

nikithacode avatar Aug 12 '25 06:08 nikithacode

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b2971346d9a23caea09d91f8801c89898d4dea77

revx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/revx/revx.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:28:	MakeRequests		83.3%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:68:	MakeBids		88.5%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:123:	getMediaTypeForImp	100.0%
total:								(statements)		88.0%

github-actions[bot] avatar Aug 20 '25 08:08 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 168eabd7f8bf5f54b615adb210038ebbbb4aa76e

revx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/revx/revx.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:28:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:83:	MakeBids		96.2%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:137:	getMediaTypeForImp	100.0%
total:								(statements)		92.9%

github-actions[bot] avatar Sep 15 '25 10:09 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 9b54370e57130ac1c4e758d76c8cd9e81a90c1cf

revx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/revx/revx.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:28:	MakeRequests		75.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:60:	MakeBids		96.2%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:114:	getMediaTypeForImp	100.0%
total:								(statements)		90.9%

github-actions[bot] avatar Sep 25 '25 08:09 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 50c53920df9307acdd54f9fa045e3356c0dea1e1

revx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/revx/revx.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:28:	MakeRequests		88.9%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:54:	MakeBids		96.2%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:108:	getMediaTypeForImp	100.0%
total:								(statements)		95.1%

github-actions[bot] avatar Sep 25 '25 11:09 github-actions[bot]

@bsardo @ccorbo @pm-jaydeep-mohite Gentle reminder to please revisit the PR Thank you for your time and support!

asifrahiman avatar Oct 27 '25 18:10 asifrahiman

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 9a9c0f9a8fa3a3ac871f9ef4be0f919e746ad36e

revx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/revx/revx.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:28:	MakeRequests		88.9%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:54:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:108:	getMediaTypeForImp	100.0%
total:								(statements)		97.6%

github-actions[bot] avatar Oct 29 '25 18:10 github-actions[bot]

@ccorbo When running ./validate.sh we are getting a new error ok github.com/prebid/prebid-server/v3/errortypes (cached) 2025/10/29 23:52:34 http: superfluous response.WriteHeader call from github.com/prebid/prebid-server/v3/exchange.TestExtraBidWithMultiCurrencies.func1 (bidder_test.go:2991) --- FAIL: TestNewExchange (0.04s) exchange_test.go:91: NewExchange produced an Exchange without bidder revx E1029 23:52:34.488998 33819 exchange.go:909] OpenRTB auction recovered panic from Bidder appnexus: panic!. Account id: test1, All Bidders: bidder1,bidder2, Stack trace is: goroutine 811 [running]: runtime/debug.Stack() /opt/homebrew/Cellar/go/1.24.3/libexec/src/runtime/debug/stack.go:26 +0x64 github.com/prebid/prebid-server/v3/exchange.TestPanicRecovery.(*exchange).recoverSafely.func2.1() /Users/asifabdulrahiman/Documents/releases/2025/May/PreBidServer/prebid-server/exchange/exchange.go:911 +0x170 panic({0x102d61720?, 0x102f4e4c0?}) /opt/homebrew/Cellar/go/1.24.3/libexec/src/runtime/panic.go:792 +0x124 github.com/prebid/prebid-server/v3/exchange.TestPanicRecovery.func1({0x1400081c000, {0x102abbe5c, 0x7}, {0x102abd685, 0x8}, {{0x102ab8234, 0x3}, {0x102ac1d38, 0xc}, {0x102abd685, ...}, ...}, ...}, ...) /Users/asifabdulrahiman/Documents/releases/2025/May/PreBidServer/prebid-server/exchange/exchange_test.go:1943 +0x2c github.com/prebid/prebid-server/v3/exchange.TestPanicRecovery.(*exchange).recoverSafely.func2({0x1400081c000, {0x102abbe5c, 0x7}, {0x102abd685, 0x8}, {{0x102ab8234, 0x3}, {0x102ac1d38, 0xc}, {0x102abd685, ...}, ...}, ...}, ...) /Users/asifabdulrahiman/Documents/releases/2025/May/PreBidServer/prebid-server/exchange/exchange.go:919 +0xbc github.com/prebid/prebid-server/v3/exchange.TestPanicRecovery(0x140002e36c0) /Users/asifabdulrahiman/Documents/releases/2025/May/PreBidServer/prebid-server/exchange/exchange_test.go:1974 +0x488 testing.tRunner(0x140002e36c0, 0x102f4a070) /opt/homebrew/Cellar/go/1.24.3/libexec/src/testing/testing.go:1792 +0xe4 created by testing.(*T).Run in goroutine 1 /opt/homebrew/Cellar/go/1.24.3/libexec/src/testing/testing.go:1851 +0x374 E1029 23:52:35.601688 33819 exchange.go:774] Exchange: bidlables for pubmatic (pubmatic) missing adapter string E1029 23:52:35.601984 33819 exchange.go:774] Exchange: bidlables for pubmatic (pubmatic) missing adapter string E1029 23:52:35.602102 33819 exchange.go:774] Exchange: bidlables for pubmatic (pubmatic) missing adapter string E1029 23:52:35.602207 33819 exchange.go:774] Exchange: bidlables for pubmatic (pubmatic) missing adapter string FAIL FAIL github.com/prebid/prebid-server/v3/exchange 6.942s Could you let me know how to fix the same?

asifrahiman avatar Oct 29 '25 18:10 asifrahiman

@asifrahiman You need to add a revx.yaml file under static/bidder-info. I see it was present in earlier commits, was it accidentally removed?

https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html, instructions under Bidder Info

ccorbo avatar Nov 05 '25 18:11 ccorbo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, cfa88b30ab74846d9e491dbb468f41482ba9ebec

revx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/revx/revx.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:28:	MakeRequests		88.9%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:54:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/revx/revx.go:108:	getMediaTypeForImp	100.0%
total:								(statements)		97.6%

github-actions[bot] avatar Nov 17 '25 07:11 github-actions[bot]

@asifrahiman You need to add a revx.yaml file under static/bidder-info. I see it was present in earlier commits, was it accidentally removed?

https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html, instructions under Bidder Info

@ccorbo It seems to have been an issue with IDE. We have re added the file. Please assist with the review.

asifrahiman avatar Nov 17 '25 07:11 asifrahiman