prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard
verified publisher icon prebid

New Adapter: Blis

Open tomaskoutny-blis opened this issue 8 months ago • 1 comments

Doc PR -> https://github.com/prebid/prebid.github.io/pull/5994

tomaskoutny-blis avatar Apr 16 '25 22:04 tomaskoutny-blis

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 3a949451d7845ad8037390bbda171c1261ef0bf8

blis

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blis/blis.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:28:	MakeRequests		92.9%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:63:	MakeBids		95.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:98:	getMediaTypeForBid	60.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:113:	resolveMacros		100.0%
total:								(statements)		91.3%

github-actions[bot] avatar Apr 16 '25 22:04 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, ec6c07b512ed7a90dfc062b0038d700ce84676dd

blis

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blis/blis.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:28:	MakeRequests		92.3%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:61:	MakeBids		95.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:96:	getMediaTypeForBid	60.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:111:	resolveMacros		100.0%
total:								(statements)		91.1%

github-actions[bot] avatar Apr 25 '25 14:04 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 1ed96309b85735a0cf5c3717666dde4154647399

blis

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blis/blis.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:28:	MakeRequests		92.3%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:61:	MakeBids		95.2%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:97:	getMediaTypeForBid	60.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:112:	resolveMacros		100.0%
total:								(statements)		91.3%

github-actions[bot] avatar May 07 '25 18:05 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4755c51933ca11c67a8ecee779ea6059a4b5877a

blis

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blis/blis.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:28:	MakeRequests		92.3%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:61:	MakeBids		95.2%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:97:	getMediaTypeForBid	60.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:112:	resolveMacros		100.0%
total:								(statements)		91.3%

github-actions[bot] avatar May 09 '25 14:05 github-actions[bot]

Hi @scr-oath , @bsardo , @linux019 can you please review the latest changes and possibly approve the PR?

tomaskoutny-blis avatar May 20 '25 10:05 tomaskoutny-blis

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 807e1c6c3986753e7231c5b5544663adf1d125a7

blis

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blis/blis.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:28:	MakeRequests		92.3%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:61:	MakeBids		95.2%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:97:	getMediaTypeForBid	60.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:112:	resolveMacros		100.0%
total:								(statements)		91.3%

github-actions[bot] avatar May 22 '25 01:05 github-actions[bot]

Hi @scr-oath , @bsardo can you please review the latest changes and possibly approve the PR?

tomaskoutny-blis avatar May 29 '25 11:05 tomaskoutny-blis

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 1dafc7b4b6190f396c34843ef871b2b29a5679c0

blis

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blis/blis.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:28:	MakeRequests		92.3%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:61:	MakeBids		95.2%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:97:	getMediaTypeForBid	60.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:112:	resolveMacros		100.0%
total:								(statements)		91.3%

github-actions[bot] avatar Jun 09 '25 21:06 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 1ad071156280508815f32ea470b74cea2977afbb

blis

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blis/blis.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:29:	MakeRequests		92.3%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:62:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:96:	getMediaTypeForBid	60.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:111:	resolveMacros		100.0%
total:								(statements)		90.9%

github-actions[bot] avatar Jun 09 '25 21:06 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4476a856b0b78d88dc91de7f4f5281fc82cbe6a7

blis

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blis/blis.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:29:	MakeRequests		92.3%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:62:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:96:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:111:	resolveMacros		100.0%
total:								(statements)		95.5%

github-actions[bot] avatar Jun 17 '25 15:06 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, e8bbc2686c25757e7d7032e3340f316d9a1c6b37

blis

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blis/blis.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:29:	MakeRequests		92.3%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:62:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:96:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:111:	resolveMacros		100.0%
total:								(statements)		95.5%

github-actions[bot] avatar Jun 25 '25 16:06 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 0f70dc881c42986fff807e829afa78d41167f654

blis

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blis/blis.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:29:	MakeRequests		92.3%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:62:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:96:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:111:	resolveMacros		100.0%
total:								(statements)		95.5%

github-actions[bot] avatar Jun 25 '25 18:06 github-actions[bot]

@bsardo @scr-oath Is there any chance our adapter gets included into the next release?

tomaskoutny-blis avatar Jun 26 '25 07:06 tomaskoutny-blis

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6f14ec4b83f793bee20b29676aff16db93590307

blis

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blis/blis.go:24:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:36:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:74:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:79:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:113:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:128:	resolveMacros		100.0%
total:								(statements)		94.2%

github-actions[bot] avatar Jun 27 '25 12:06 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 238d098d4a19bccc6744317bc836d7c28715f80f

blis

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blis/blis.go:24:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:36:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:74:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:79:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:113:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:128:	resolveMacros		100.0%
total:								(statements)		94.2%

github-actions[bot] avatar Jul 15 '25 21:07 github-actions[bot]

@bsardo @scr-oath @pm-jaydeep-mohite Is there any chance our adapter gets included into the next release?

tomaskoutny-blis avatar Jul 15 '25 21:07 tomaskoutny-blis

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 55ccc3a121bc6ff1841d537bb8308778daf7b376

blis

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blis/blis.go:24:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:36:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:74:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:79:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:113:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:128:	resolveMacros		100.0%
total:								(statements)		94.2%

github-actions[bot] avatar Jul 22 '25 15:07 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 56540db73f357acad2fa5011693d62033ca3d7a7

blis

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blis/blis.go:24:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:36:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:74:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:79:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:113:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:128:	resolveMacros		100.0%
total:								(statements)		94.2%

github-actions[bot] avatar Jul 22 '25 19:07 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f172f95013c72632d417fbede1917c1d2d9645a9

blis

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blis/blis.go:24:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:36:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:74:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:79:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:113:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:128:	resolveMacros		100.0%
total:								(statements)		94.2%

github-actions[bot] avatar Jul 23 '25 16:07 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, a2b80aef7259450436fc7af1f12319ee4c173eed

blis

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blis/blis.go:24:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:36:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:74:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:79:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:113:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/blis/blis.go:128:	resolveMacros		100.0%
total:								(statements)		94.2%

github-actions[bot] avatar Jul 25 '25 10:07 github-actions[bot]

@scr-oath Any chance there is anything wrong with the validate pipeline? It's not clear to me why it's failing. Runs fine on my host with Go 1.23.1.

tomaskoutny-blis avatar Jul 28 '25 16:07 tomaskoutny-blis

@scr-oath Any chance there is anything wrong with the validate pipeline? It's not clear to me why it's failing. Runs fine on my host with Go 1.23.1.

It failed due to a flaky test. I just restarted the job.

bsardo avatar Jul 28 '25 16:07 bsardo

@scr-oath Any chance there is anything wrong with the validate pipeline? It's not clear to me why it's failing. Runs fine on my host with Go 1.23.1.

It failed due to a flaky test. I just restarted the job.

Thanks @bsardo . Can you also re-run the one for 1.23.x?

tomaskoutny-blis avatar Jul 28 '25 16:07 tomaskoutny-blis