GumGum: Update Prebid Server Adapter (Go) to collect the ad unit name for reporting

[ShayanK16GumGum]

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, d1f92794cde0ff6ce894e64ae4e59463372e3c56

gumgum

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:24:	MakeRequests		87.1%
github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:85:	MakeBids		81.0%
github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:131:	preprocess		71.4%
github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:204:	getBiggerFormat		100.0%
github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:228:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:238:	Builder			100.0%
total:									(statements)		82.5%

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, 4988def5fcabf4a38cae191cde400e0b35623e63

gumgum

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:24:	MakeRequests		87.1%
github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:85:	MakeBids		81.0%
github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:131:	preprocess		69.8%
github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:206:	getBiggerFormat		100.0%
github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:230:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:240:	Builder			100.0%
total:									(statements)		81.7%

[ShayanK16GumGum]

@ccorbo please have a look.

[ShayanK16GumGum]

Hi @ccorbo , I need one more approval for the PR to be ready for merging.

[bsardo]

@ShayanK16GumGum as you can see above if you click through to view the validate check results, it looks like a test you modified is failing: "test_json.go:129: sovrntest/supplemental/adunitcode.json: MakeRequests had wrong error count. Expected 0, got 1 ([Missing required parameter 'tagid'])".

Did you intend to modify this file? It is for a different adapter. Can you please make the necessary fix?

[ShayanK16GumGum]

Hey @bsardo , looking into it.

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, 74db71932687c2b5db40a2b165111e1cb8047ca6

gumgum

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:24:	MakeRequests		87.1%
github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:85:	MakeBids		81.0%
github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:131:	preprocess		74.4%
github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:191:	getBiggerFormat		100.0%
github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:215:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v3/adapters/gumgum/gumgum.go:225:	Builder			100.0%
total:									(statements)		83.8%

sovrn

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:29:	MakeRequests		84.6%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:135:	addHeaderIfNonEmpty	100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:141:	MakeBids		84.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:195:	getExtBidFloor		100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:207:	getTagId		100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:215:	getImpIdx		100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:228:	Builder			100.0%
total:								(statements)		87.1%

[ShayanK16GumGum]

@ShayanK16GumGum as you can see above if you click through to view the validate check results, it looks like a test you modified is failing: "test_json.go:129: sovrntest/supplemental/adunitcode.json: MakeRequests had wrong error count. Expected 0, got 1 ([Missing required parameter 'tagid'])".

Did you intend to modify this file? It is for a different adapter. Can you please make the necessary fix?

Hi @bsardo , I have reverted my changes. I was just testing with another json. In have added back the json form master. It is passing for me now. Please have a look. Sorry for the inconvenience. FYI: @pm-isha-bharti @jney