prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

Seedtag Adapter: fix required content-type header on http calls

Open sangarbe opened this issue 8 months ago • 1 comments

We were missing to add the required content-type headers to request Seedtag server-to-server endpoint. This situation lead to unparsed body payloads for the first integrations.

sangarbe avatar Apr 14 '25 07:04 sangarbe

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, bd2751b71e431a4dea4c0c4ef709a7feb2915dee

seedtag

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/seedtag/seedtag.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/seedtag/seedtag.go:28:	MakeRequests		95.7%
github.com/prebid/prebid-server/v3/adapters/seedtag/seedtag.go:76:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/seedtag/seedtag.go:115:	getMediaTypeForBid	100.0%
total:									(statements)		97.9%

github-actions[bot] avatar Apr 14 '25 07:04 github-actions[bot]

@pm-jaydeep-mohite can you please review?

bsardo avatar Apr 28 '25 21:04 bsardo

Hi there @bsardo and @guscarreon ! Is there any possibility to have a second approval soon? I'm sorry to bother you, we have a workaround on our side that we must remove and clients waiting for the release of this change.

sangarbe avatar May 15 '25 06:05 sangarbe

Hi @bsardo and @guscarreon ! Any updates on this PR. If you need me to action anything just let me know

sangarbe avatar Jun 03 '25 06:06 sangarbe

@sangarbe thanks for your patience. We will get this into the next release.

bsardo avatar Jun 13 '25 16:06 bsardo

Hi @bsardo ! You told me this would be added to next release, but it didn't. Is there any problem I need to tackle?

sangarbe avatar Jun 25 '25 07:06 sangarbe

Hi @bsardo ! You told me this would be added to next release, but it didn't. Is there any problem I need to tackle?

Hi @sangarbe, sorry I was out last week and did not build the last release. I will get this into this week's release.

bsardo avatar Jun 25 '25 13:06 bsardo