prebid-server
prebid-server copied to clipboard
Cnvr Adapter: enable native requests
Add support for native requests to the conversant prebid-server adapter
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, b27f0b5de4d1eb5e5a446882f2409efb57c212d9
conversant
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/conversant/conversant.go:22: MakeRequests 93.3%
github.com/prebid/prebid-server/v3/adapters/conversant/conversant.go:85: parseCnvrParams 97.4%
github.com/prebid/prebid-server/v3/adapters/conversant/conversant.go:156: MakeBids 92.9%
github.com/prebid/prebid-server/v3/adapters/conversant/conversant.go:191: getBidType 100.0%
github.com/prebid/prebid-server/v3/adapters/conversant/conversant.go:209: Builder 100.0%
total: (statements) 95.7%
Code LGTM but can you add declaration for support for native to yaml file here: https://github.com/prebid/prebid-server/blob/master/static/bidder-info/conversant.yaml
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 6b3147462dc6ac5c7e1abe8f33f385c1b5fcf4a1
conversant
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/conversant/conversant.go:22: MakeRequests 93.3%
github.com/prebid/prebid-server/v3/adapters/conversant/conversant.go:85: parseCnvrParams 97.4%
github.com/prebid/prebid-server/v3/adapters/conversant/conversant.go:156: MakeBids 92.9%
github.com/prebid/prebid-server/v3/adapters/conversant/conversant.go:191: getBidType 100.0%
github.com/prebid/prebid-server/v3/adapters/conversant/conversant.go:209: Builder 100.0%
total: (statements) 95.7%