prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

New Adapter: Sparteo

Open t-sormonte opened this issue 9 months ago • 19 comments

🏷 Type of documentation

  • [x] new bid adapter

📋 Checklist

Prebid Docs Initial PR: https://github.com/prebid/prebid.github.io/pull/4917 Prebid Docs Update PR: https://github.com/prebid/prebid.github.io/pull/5644

t-sormonte avatar Mar 21 '25 17:03 t-sormonte

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7460192a3b0e0a8b9567b80349a999057f1f3899

sparteo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:25:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:32:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:53:	MakeRequests	87.9%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:166:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:201:	getMediaType	100.0%
total:									(statements)	92.4%

github-actions[bot] avatar Mar 21 '25 17:03 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7460192a3b0e0a8b9567b80349a999057f1f3899

sparteo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:25:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:32:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:53:	MakeRequests	87.9%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:166:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:201:	getMediaType	100.0%
total:									(statements)	92.4%

github-actions[bot] avatar Mar 25 '25 10:03 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 49d8d7687ddecdff73e4d9e10b74b1e15c2c0998

sparteo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:25:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:32:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:53:	MakeRequests	87.7%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:165:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:200:	getMediaType	100.0%
total:									(statements)	92.3%

github-actions[bot] avatar Mar 25 '25 15:03 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6aa81a4bd02a2511867479b834e1fc91cf86f570

sparteo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:25:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:32:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:53:	MakeRequests	87.7%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:165:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:200:	getMediaType	100.0%
total:									(statements)	92.3%

github-actions[bot] avatar Mar 26 '25 08:03 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 089767318475be56f6231e822e981c5ca2abfeff

sparteo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:25:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:32:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:53:	MakeRequests	87.7%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:165:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:200:	getMediaType	100.0%
total:									(statements)	92.3%

github-actions[bot] avatar Mar 26 '25 08:03 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, beb5a41b63f8a9d7b3d5a7e39ff0b74146625266

sparteo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:25:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:32:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:53:	MakeRequests	87.7%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:165:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:200:	getMediaType	100.0%
total:									(statements)	92.3%

github-actions[bot] avatar Mar 27 '25 10:03 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, a96764288dec8b3445d1e0add7d7fc56ff1c3dd1

sparteo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:25:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:32:	parseExt	88.9%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:53:	MakeRequests	86.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:165:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:198:	getMediaType	90.0%
total:									(statements)	89.2%

github-actions[bot] avatar Apr 02 '25 09:04 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 53aaa71754e6c79c69e370fcb5db6808486df3d0

sparteo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:25:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:32:	parseExt	88.9%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:49:	MakeRequests	86.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:157:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:190:	getMediaType	90.0%
total:									(statements)	89.2%

github-actions[bot] avatar Apr 02 '25 10:04 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, d59ba9cb831f5f5e3eefa2c1ea03c486f532d21a

sparteo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:25:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:32:	parseExt	88.9%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:49:	MakeRequests	86.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:157:	MakeBids	95.2%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:202:	getMediaType	90.0%
total:									(statements)	88.8%

github-actions[bot] avatar Apr 02 '25 12:04 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 8a0336060e2d3179f398a39a3cb8685b76c79270

sparteo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:25:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:32:	parseExt	88.9%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:49:	MakeRequests	85.7%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:166:	MakeBids	95.2%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:211:	getMediaType	90.0%
total:									(statements)	88.5%

github-actions[bot] avatar Apr 03 '25 12:04 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 023f8cec642fd6ce516bbca1618af51fc494fd45

sparteo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:24:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:31:	parseExt	88.9%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:48:	MakeRequests	85.7%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:165:	MakeBids	95.2%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:210:	getMediaType	90.0%
total:									(statements)	88.5%

github-actions[bot] avatar Apr 03 '25 15:04 github-actions[bot]

Not going to approve until the usersync endpoint is functional but code LGTM

ccorbo avatar Apr 03 '25 16:04 ccorbo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, ac8151e0c9420f750b95adb447b75bcf6de39596

sparteo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:24:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:31:	parseExt	88.9%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:48:	MakeRequests	85.7%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:165:	MakeBids	95.2%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:210:	getMediaType	90.0%
total:									(statements)	88.5%

github-actions[bot] avatar Apr 07 '25 13:04 github-actions[bot]

Not going to approve until the usersync endpoint is functional but code LGTM

Hi @ccorbo , The s2s cookie sync endpoint is now live. I also have squashed the commits. Thank you again for your time and guidance.

t-sormonte avatar Apr 07 '25 13:04 t-sormonte

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, adfa48a5f3be7ed04a323cbc2cf0e9b604e6ed36

sparteo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:24:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:31:	parseExt	88.9%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:48:	MakeRequests	85.7%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:165:	MakeBids	95.2%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:210:	getMediaType	90.0%
total:									(statements)	88.5%

github-actions[bot] avatar Apr 07 '25 13:04 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, d233acba732af44aadcffd8e24bb59334dc07feb

sparteo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:24:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:31:	parseExt	88.9%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:48:	MakeRequests	85.7%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:165:	MakeBids	95.2%
github.com/prebid/prebid-server/v3/adapters/sparteo/sparteo.go:210:	getMediaType	90.0%
total:									(statements)	88.5%

github-actions[bot] avatar Apr 08 '25 14:04 github-actions[bot]

Verified maintainer email addr: image

ccorbo avatar Apr 08 '25 20:04 ccorbo

Hi @ccorbo , Thank you again for your approval, have you got an idea on when this adapter could be released (even approximatively)?

t-sormonte avatar Apr 10 '25 09:04 t-sormonte

@t-sormonte This PR requires an additional approval from another reviewer. It is in the queue. I apologize I don't have a exact timeframe

@bsardo This PR needs an additional review if you can assign someone

ccorbo avatar Apr 10 '25 16:04 ccorbo

Hi @ccorbo, @bsardo, Do you have any updates on the PR approval? Thanks in advance for your help.

nicolasrenel85 avatar Apr 24 '25 07:04 nicolasrenel85

@t-sormonte @nicolasrenel85 we'll get another reviewer on it. Sorry for the delay. There's a lot in the queue at the moment.

bsardo avatar Apr 24 '25 14:04 bsardo

Hi @ccorbo @bsardo @hhhjort , do you have an ETA for the release of this adapter ? Is it planned to be included in the next release version ? Thanks team

t-sormonte avatar May 15 '25 12:05 t-sormonte

Hi @ccorbo @bsardo @hhhjort , do you know if we are planned to be included in the next release version ? Do you have an approximative ETA for the release of this adapter ? Thanks team

t-sormonte avatar Jun 17 '25 07:06 t-sormonte

Hi @t-sormonte, we should get this into the release this week.

bsardo avatar Jun 25 '25 13:06 bsardo