prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

New Adapter: Flatads

Open flatads opened this issue 9 months ago • 9 comments

flatads avatar Mar 04 '25 05:03 flatads

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 16888dcc6d01ba61013f2c30bfc7519b8d1918f0

flatads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:33:	MakeRequests			92.3%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:84:	buildEndpointFromRequest	87.5%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:107:	MakeBids			94.4%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:142:	getMediaTypeForBid		88.9%
total:									(statements)			92.4%

github-actions[bot] avatar Mar 04 '25 05:03 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 2df21b2c90b0cf3275fa25c964bf6636b8d5ab99

flatads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:33:	MakeRequests			92.3%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:84:	buildEndpointFromRequest	87.5%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:107:	MakeBids			94.4%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:142:	getMediaTypeForBid		88.9%
total:									(statements)			92.4%

github-actions[bot] avatar Mar 05 '25 03:03 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 074a59ec5a745abfaf6589f52495b1d269578def

flatads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:33:	MakeRequests			92.3%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:84:	buildEndpointFromRequest	87.5%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:107:	MakeBids			94.4%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:142:	getMediaTypeForBid		88.9%
total:									(statements)			92.4%

github-actions[bot] avatar Mar 05 '25 03:03 github-actions[bot]

@pm-jaydeep-mohite can you please review?

bsardo avatar Mar 06 '25 17:03 bsardo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, d3d0bfa1a38e3bd005ff72e93e655625916d673f

flatads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:33:	MakeRequests			92.3%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:83:	buildEndpointFromRequest	87.5%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:106:	MakeBids			94.4%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:140:	getMediaTypeForBid		88.9%
total:									(statements)			92.4%

github-actions[bot] avatar Mar 12 '25 06:03 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 46e614c973c9f55ca6f55536f066ce45cf6abf77

flatads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:33:	MakeRequests			92.3%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:83:	buildEndpointFromRequest	100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:106:	MakeBids			100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:142:	getMediaTypeForBid		100.0%
total:									(statements)			97.1%

github-actions[bot] avatar Mar 12 '25 09:03 github-actions[bot]

Confirmed usersync endpoint image

ccorbo avatar Mar 17 '25 19:03 ccorbo

docs pr: https://github.com/prebid/prebid.github.io/pull/5920

muuki88 avatar Mar 17 '25 20:03 muuki88

@bsardo It has been approved for two weeks. May I ask when the branch will be merged?

flatads avatar Apr 03 '25 02:04 flatads

@flatads please see recent comments. We are close.

bsardo avatar Apr 24 '25 14:04 bsardo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7238724aedfabb946c7f54b975c47a5a52941974

flatads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:33:	MakeRequests			92.3%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:83:	buildEndpointFromRequest	100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:106:	MakeBids			100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:142:	getMediaTypeForBid		100.0%
total:									(statements)			97.1%

github-actions[bot] avatar May 13 '25 02:05 github-actions[bot]

Left some comments related to code cleanup. Other than these looks good.

@VeronikaSolovei9 I have revised the code according to the suggestions.

flatads avatar May 13 '25 02:05 flatads

@przemkaczmarek I have revised the code according to the suggestions.

flatads avatar Jun 13 '25 07:06 flatads

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 0d6a35c6d71c35cc7c684bc6fa5715ad366ee62e

flatads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:33:	MakeRequests			92.3%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:83:	buildEndpointFromRequest	100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:106:	MakeBids			100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:142:	getMediaTypeForBid		100.0%
total:									(statements)			97.1%

github-actions[bot] avatar Jun 13 '25 07:06 github-actions[bot]