New Adapter: Flatads
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 16888dcc6d01ba61013f2c30bfc7519b8d1918f0
flatads
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:21: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:33: MakeRequests 92.3%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:84: buildEndpointFromRequest 87.5%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:107: MakeBids 94.4%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:142: getMediaTypeForBid 88.9%
total: (statements) 92.4%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 2df21b2c90b0cf3275fa25c964bf6636b8d5ab99
flatads
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:21: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:33: MakeRequests 92.3%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:84: buildEndpointFromRequest 87.5%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:107: MakeBids 94.4%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:142: getMediaTypeForBid 88.9%
total: (statements) 92.4%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 074a59ec5a745abfaf6589f52495b1d269578def
flatads
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:21: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:33: MakeRequests 92.3%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:84: buildEndpointFromRequest 87.5%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:107: MakeBids 94.4%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:142: getMediaTypeForBid 88.9%
total: (statements) 92.4%
@pm-jaydeep-mohite can you please review?
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, d3d0bfa1a38e3bd005ff72e93e655625916d673f
flatads
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:21: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:33: MakeRequests 92.3%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:83: buildEndpointFromRequest 87.5%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:106: MakeBids 94.4%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:140: getMediaTypeForBid 88.9%
total: (statements) 92.4%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 46e614c973c9f55ca6f55536f066ce45cf6abf77
flatads
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:21: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:33: MakeRequests 92.3%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:83: buildEndpointFromRequest 100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:106: MakeBids 100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:142: getMediaTypeForBid 100.0%
total: (statements) 97.1%
Confirmed usersync endpoint
docs pr: https://github.com/prebid/prebid.github.io/pull/5920
@bsardo It has been approved for two weeks. May I ask when the branch will be merged?
@flatads please see recent comments. We are close.
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 7238724aedfabb946c7f54b975c47a5a52941974
flatads
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:21: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:33: MakeRequests 92.3%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:83: buildEndpointFromRequest 100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:106: MakeBids 100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:142: getMediaTypeForBid 100.0%
total: (statements) 97.1%
Left some comments related to code cleanup. Other than these looks good.
@VeronikaSolovei9 I have revised the code according to the suggestions.
@przemkaczmarek I have revised the code according to the suggestions.
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 0d6a35c6d71c35cc7c684bc6fa5715ad366ee62e
flatads
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:21: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:33: MakeRequests 92.3%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:83: buildEndpointFromRequest 100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:106: MakeBids 100.0%
github.com/prebid/prebid-server/v3/adapters/flatads/flatads.go:142: getMediaTypeForBid 100.0%
total: (statements) 97.1%