prebid-server New Adapter: Mobkoi

Feb 26 '25 20:02 Ventilateur

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, fe4fc933ef2e101ddfd7a5cb848683dca7087e2e

mobkoi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:29:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:36:	MakeRequests	87.0%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:83:	MakeBids	71.4%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:138:	replaceMacros	100.0%
total:									(statements)	82.4%

Feb 26 '25 20:02 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 0050bae364a68b74bcf4238aceb0f6389ddad590

mobkoi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:29:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:36:	MakeRequests	87.0%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:83:	MakeBids	71.4%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:140:	replaceMacros	100.0%
total:									(statements)	82.4%

Feb 26 '25 20:02 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 70dc74d84c2afb73dd625bb68dee8dc87f414466

mobkoi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:29:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:36:	MakeRequests	87.0%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:83:	MakeBids	71.4%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:140:	replaceMacros	100.0%
total:									(statements)	82.4%

Feb 26 '25 20:02 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, c90b436d20c7fab3a16ae765d514a33349993b98

mobkoi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:29:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:36:	MakeRequests	87.0%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:83:	MakeBids	71.4%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:139:	replaceMacros	100.0%
total:									(statements)	82.4%

Feb 27 '25 07:02 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 6109ae55f75c06a1c1c4cfc9edb8ebcd7a7bdffe

mobkoi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:29:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:36:	MakeRequests	87.0%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:83:	MakeBids	72.7%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:141:	replaceMacros	100.0%
total:									(statements)	82.7%

Feb 27 '25 08:02 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 9e6d8e56b6895a4a657dd61c1a2d1dce56569a73

mobkoi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:29:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:36:	MakeRequests	87.0%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:83:	MakeBids	72.7%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:141:	replaceMacros	100.0%
total:									(statements)	82.7%

Feb 27 '25 08:02 github-actions[bot]

@pm-isha-bharti can you please review?

Mar 06 '25 17:03 bsardo

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 628ea5c925cd1628c0050a539a0397392fc95ffe

mobkoi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:35:	MakeRequests	91.3%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:82:	MakeBids	100.0%
total:									(statements)	95.3%

Mar 08 '25 21:03 github-actions[bot]

Please link the PR for the documentation update for Mobkoi Prebid server adapter

Mar 10 '25 11:03 pm-isha-bharti

Here is the doc PR: https://github.com/prebid/prebid.github.io/pull/5934

Mar 10 '25 20:03 Ventilateur

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, abfdee0158197a33284e02ba24df69f0caab9770

mobkoi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:26:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:33:	MakeRequests	91.3%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:80:	MakeBids	100.0%
total:									(statements)	94.7%

Mar 10 '25 20:03 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 572d09e06006465bfc40580211ecc2675d136b3e

mobkoi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:35:	MakeRequests	92.3%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:86:	MakeBids	100.0%
total:									(statements)	95.1%

Mar 25 '25 23:03 github-actions[bot]

Can I have another review round please? Thanks

Apr 01 '25 14:04 Ventilateur

Hi @guscarreon can I have a review from you? I need two. Thanks.

Apr 11 '25 12:04 Ventilateur

@bsardo can I have a review from you? I need two. Thanks.

Apr 17 '25 15:04 Ventilateur

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 5555289d85bb44ac4cf3ab0a76f509ffa3ee2083

mobkoi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:29:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:36:	MakeRequests	92.9%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:93:	MakeBids	100.0%
total:									(statements)	95.3%

Apr 21 '25 20:04 github-actions[bot]

Hi @pm-isha-bharti sorry but your approval was dismissed, can you make another pass please? Thanks

Apr 21 '25 22:04 Ventilateur

@guscarreon @pm-isha-bharti Thank you. If I'm not mistaken, I should wait for the merge, and the adapter in java will be ported in a delay of 2-3 months. I wonder if we should wait or can we just implement the java adapter ourselves? Sorry if it's out of scope for this PR but if you can point me to some guidance on that or someone from the java maintainers?

Apr 22 '25 12:04 Ventilateur

@guscarreon @pm-isha-bharti Thank you. If I'm not mistaken, I should wait for the merge, and the adapter in java will be ported in a delay of 2-3 months. I wonder if we should wait or can we just implement the java adapter ourselves? Sorry if it's out of scope for this PR but if you can point me to some guidance on that or someone from the java maintainers?

@Ventilateur I created Port PR from PBS-Go: New Adapter: Mobkoi which will be triaged by next Friday at the latest which is when we have our next backlog meeting. In the meantime, you can raise this point on that issue. I suggest pinging @Net-burst to discuss.

Apr 22 '25 16:04 bsardo