prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

Pubmatic: Set bid.meta.mediaType=video when bid.ext.ibv=true

Open pm-priyanka-bagade opened this issue 10 months ago • 8 comments

pm-priyanka-bagade avatar Feb 03 '25 07:02 pm-priyanka-bagade

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 57cb1d2cb5da365c334dbe01fa9ba3a6b31b4e0b

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:86:	MakeRequests				93.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:196:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:239:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:247:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:255:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:352:	extractPubmaticExtFromRequest		96.6%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:403:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:421:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:435:	MakeBids				91.5%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:523:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:545:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:557:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:570:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:585:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:635:	getStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:648:	getMediaTypeForBid			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:670:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:679:	getDisplayManagerAndVer			100.0%
total:									(statements)				93.5%

github-actions[bot] avatar Feb 03 '25 07:02 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 96bff2257f2f6c0311fd0bd4640fb9c861d1855a

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:86:	MakeRequests				93.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:196:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:239:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:247:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:255:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:352:	extractPubmaticExtFromRequest		96.6%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:403:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:421:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:435:	MakeBids				91.5%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:523:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:545:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:557:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:570:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:585:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:635:	getStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:648:	getMediaTypeForBid			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:670:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:679:	getDisplayManagerAndVer			100.0%
total:									(statements)				93.5%

github-actions[bot] avatar Feb 03 '25 11:02 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, e1f0fbe7779ce9654d16e2972abc688180d1f249

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:86:	MakeRequests				93.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:196:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:239:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:247:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:255:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:352:	extractPubmaticExtFromRequest		96.6%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:403:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:421:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:435:	MakeBids				88.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:528:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:550:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:562:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:575:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:590:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:640:	getStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:653:	getMediaTypeForBid			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:676:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:685:	getDisplayManagerAndVer			100.0%
total:									(statements)				92.9%

github-actions[bot] avatar Feb 14 '25 01:02 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 446ec4a558ce6c12f989ebcc89ed9fa8814dee0d

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:86:	MakeRequests				93.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:196:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:239:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:247:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:255:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:352:	extractPubmaticExtFromRequest		96.6%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:403:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:421:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:435:	MakeBids				88.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:528:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:550:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:562:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:575:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:590:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:640:	getStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:653:	getMediaTypeForBid			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:676:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:685:	getDisplayManagerAndVer			100.0%
total:									(statements)				92.9%

github-actions[bot] avatar Feb 14 '25 01:02 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5aa750e71b57a54bc31816579974f311b07038bd

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:86:	MakeRequests				93.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:196:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:239:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:247:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:255:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:352:	extractPubmaticExtFromRequest		96.6%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:403:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:421:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:435:	MakeBids				88.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:528:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:550:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:562:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:575:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:590:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:640:	getStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:653:	getMediaTypeForBid			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:676:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:685:	getDisplayManagerAndVer			100.0%
total:									(statements)				92.9%

github-actions[bot] avatar Feb 14 '25 01:02 github-actions[bot]

@guscarreon / @scr-oath Can someone please review this PR?

pm-isha-bharti avatar Mar 10 '25 09:03 pm-isha-bharti

Hi @pm-priyanka-bagade, please see recent comments.

bsardo avatar Apr 07 '25 15:04 bsardo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, dd73a53bd9f9af866d3a7c22ed8beb95302ce4ec

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:86:	MakeRequests				93.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:196:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:239:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:247:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:255:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:352:	extractPubmaticExtFromRequest		96.6%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:403:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:421:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:435:	MakeBids				92.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:528:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:550:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:562:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:575:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:590:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:640:	getStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:653:	getMediaTypeForBid			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:676:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:685:	getDisplayManagerAndVer			100.0%
total:									(statements)				93.6%

github-actions[bot] avatar Apr 18 '25 10:04 github-actions[bot]

@guscarreon Can you please review this PR again? Resolved all the comments.

pm-priyanka-bagade avatar Apr 22 '25 08:04 pm-priyanka-bagade

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 58b1910dcd4ebb07d04f53a86675151ea28b9633

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:86:	MakeRequests				93.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:196:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:239:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:247:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:255:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:352:	extractPubmaticExtFromRequest		96.6%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:403:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:421:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:435:	MakeBids				92.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:528:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:550:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:562:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:575:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:590:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:640:	getStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:653:	getMediaTypeForBid			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:676:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:685:	getDisplayManagerAndVer			100.0%
total:									(statements)				93.6%

github-actions[bot] avatar Apr 25 '25 10:04 github-actions[bot]

Please check @guscarreon Resolved all the comments.

pm-priyanka-bagade avatar Apr 25 '25 10:04 pm-priyanka-bagade

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 797b986e740126f0d009e94f7956f7debcca79fc

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:86:	MakeRequests				93.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:196:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:239:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:247:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:255:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:352:	extractPubmaticExtFromRequest		96.6%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:403:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:421:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:435:	MakeBids				91.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:528:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:550:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:562:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:575:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:590:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:640:	getStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:653:	getMediaTypeForBid			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:676:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:685:	getDisplayManagerAndVer			100.0%
total:									(statements)				93.5%

github-actions[bot] avatar May 05 '25 12:05 github-actions[bot]

@guscarreon / @bsardo Please check and merge

pm-priyanka-bagade avatar May 05 '25 12:05 pm-priyanka-bagade

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f7d1aa0d28b07b15582578ddfc2b751e12237da4

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:86:	MakeRequests				93.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:196:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:239:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:247:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:255:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:352:	extractPubmaticExtFromRequest		96.6%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:403:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:421:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:435:	MakeBids				91.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:528:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:550:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:562:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:575:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:590:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:640:	getStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:653:	getMediaTypeForBid			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:676:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:685:	getDisplayManagerAndVer			100.0%
total:									(statements)				93.5%

github-actions[bot] avatar May 07 '25 12:05 github-actions[bot]

@guscarreon Could you please review it again? Thanks!

pm-isha-bharti avatar May 13 '25 05:05 pm-isha-bharti

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 9a527067620e6305a837ba00467855e9d3a0f9a0

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:86:	MakeRequests				93.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:196:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:239:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:247:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:255:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:352:	extractPubmaticExtFromRequest		96.6%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:403:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:421:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:435:	MakeBids				91.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:528:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:550:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:562:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:575:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:590:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:640:	getStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:653:	getMediaTypeForBid			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:676:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:685:	getDisplayManagerAndVer			100.0%
total:									(statements)				93.5%

github-actions[bot] avatar Jun 13 '25 08:06 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 088fd4653a37fcecbfc0cdbea47c485e84f8a179

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:85:	MakeRequests				93.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:195:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:238:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:246:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:254:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:351:	extractPubmaticExtFromRequest		96.6%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:402:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:420:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:434:	MakeBids				91.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:526:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:548:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:560:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:573:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:588:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:638:	getStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:651:	getMediaTypeForBid			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:674:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:683:	getDisplayManagerAndVer			100.0%
total:									(statements)				93.5%

github-actions[bot] avatar Jun 25 '25 10:06 github-actions[bot]