Missena: Update params
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 9144aec399da704df753c60c5599d608db2f325b
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:76: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:83: getCurrency 77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:99: makeRequest 87.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:165: MakeRequests 91.3%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:209: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:229: MakeBids 94.1%
total: (statements) 90.7%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 091ffa966ff6dffb317868171fe6683b0aafeb9d
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:76: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:83: getCurrency 77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:99: makeRequest 87.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:165: MakeRequests 91.3%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:209: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:229: MakeBids 94.1%
total: (statements) 90.7%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 9398c8a00cc0d48c7c2213f7b905b0e8182cb684
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:76: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:83: getCurrency 77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:99: makeRequest 87.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:165: MakeRequests 91.3%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:208: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:228: MakeBids 94.1%
total: (statements) 90.7%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 75e77ba93a1b2a101972533e4076396c311af736
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:76: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:83: getCurrency 77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:99: makeRequest 87.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:165: MakeRequests 91.3%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:208: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:228: MakeBids 94.1%
total: (statements) 90.7%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 7c9274420c0b022ee06e99b7e9ffb2451e147763
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:64: Builder 80.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:75: getCurrency 77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:91: getEndPoint 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:98: makeRequest 84.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:167: MakeRequests 89.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:201: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:221: MakeBids 94.1%
total: (statements) 88.8%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, dd7c2c1def53d23a872cf4bf4ebfa05c8baccd76
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:64: Builder 80.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:75: getCurrency 77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:91: getEndPoint 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:98: makeRequest 84.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:167: MakeRequests 89.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:201: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:221: MakeBids 94.1%
total: (statements) 88.8%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 8f5c3f54f5b0ae4d6af40a7381d2354408502968
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:66: Builder 80.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:77: getCurrency 77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:93: getEndPoint 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:100: makeRequest 68.6%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:182: MakeRequests 89.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:216: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:236: MakeBids 94.1%
total: (statements) 82.8%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 5b606eb3613f4e0069e46b9a1ac76c93ea1ef2bd
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:66: Builder 80.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:77: getCurrency 77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:93: getEndPoint 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:100: makeRequest 75.6%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:198: MakeRequests 89.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:232: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:252: MakeBids 94.1%
total: (statements) 84.4%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 94483f476c365b661b807682fd88cba65d8cc536
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:65: Builder 80.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:76: getCurrency 77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:92: getEndPoint 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:99: makeRequest 68.6%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:181: MakeRequests 89.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:215: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:235: MakeBids 94.1%
total: (statements) 82.8%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, bdf8b0990febb6ef76dbfedcab1aa2459c84ec20
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:65: Builder 80.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:76: getCurrency 77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:92: getEndPoint 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:99: makeRequest 68.6%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:181: MakeRequests 89.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:217: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:237: MakeBids 94.1%
total: (statements) 82.8%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, d51cb80395cf0e070abb00e11f331463dab3431a
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:65: Builder 80.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:76: getCurrency 77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:92: getEndPoint 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:99: makeRequest 68.6%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:181: MakeRequests 89.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:217: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:237: MakeBids 94.1%
total: (statements) 82.8%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, b1dee70295c62f11172ed95e18c39d9dd0ea8570
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:66: Builder 80.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:77: getCurrency 77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:93: getEndPoint 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:100: makeRequest 68.6%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:183: MakeRequests 89.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:219: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:239: MakeBids 94.1%
total: (statements) 82.8%
This comment is not addressed.
If request.User, request.Regs and request.Site are required - please add validation and error handling.
If not - then set default values (if not passed already in request) to avoid null pointer exception.
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 0efc02d29c7a0f16810b13dc26129c95815299c3
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:66: Builder 80.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:77: getCurrency 77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:93: getEndPoint 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:100: makeRequest 71.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:188: MakeRequests 89.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:224: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:244: MakeBids 94.1%
total: (statements) 83.5%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 4ecf9a74a81747c6434050463cbfe33f580a924d
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:66: Builder 80.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:77: getCurrency 88.9%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:93: getEndPoint 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:100: makeRequest 79.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:188: MakeRequests 89.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:224: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:244: MakeBids 94.1%
total: (statements) 87.4%
@jney you're experiencing validate test failures because your commit history contains a commit with a known bug that has since been reverted. Merging with master should resolve the issue.
@jney please see comment. We'll need those nil checks to avoid potential panics.
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 1effa1e9f79926dab83f81ee53be7063e125fbf3
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:66: Builder 80.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:77: getCurrency 88.9%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:93: getEndPoint 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:100: makeRequest 79.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:188: MakeRequests 89.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:224: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:244: MakeBids 94.1%
total: (statements) 87.4%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 4c31987f9b825b0cca0a5db8a3fd0b39047767ee
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:66: Builder 80.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:77: getCurrency 88.9%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:93: getEndPoint 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:100: makeRequest 79.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:189: MakeRequests 89.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:225: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:245: MakeBids 94.1%
total: (statements) 87.4%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, ec137feb350554a225a50d95695761a8d223f863
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:66: Builder 80.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:77: getCurrency 88.9%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:93: getEndPoint 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:100: makeRequest 84.3%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:208: MakeRequests 89.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:244: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:264: MakeBids 94.1%
total: (statements) 88.7%
@jney please see comment. We'll need those nil checks to avoid potential panics.
@bsardo @VeronikaSolovei9 Please check the latest commit
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 30f9fae6e4eea4b1bd8faf81d1f77e28c0b4c2c3
missena
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:66: Builder 80.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:77: getCurrency 88.9%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:93: getEndPoint 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:100: makeRequest 84.3%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:208: MakeRequests 89.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:244: readGDPR 100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:264: MakeBids 94.1%
total: (statements) 88.7%
@ysfbsf @jney can you please open a docs PR to update the bidder params section of https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/missena.md with the two new params formats and settings and then provide the link to the PR here?
Once that is done we can merge. Thanks!
@ysfbsf @jney can you please open a docs PR to update the bidder params section of https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/missena.md with the two new params
formatsandsettingsand then provide the link to the PR here? Once that is done we can merge. Thanks!
@bsardo Please find the PR as requested: https://github.com/prebid/prebid.github.io/pull/6013/