prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

New Adapter: Zentotem

Open zentotem opened this issue 1 year ago • 5 comments

Docs: https://github.com/prebid/prebid.github.io/pull/5553

zentotem avatar Nov 13 '24 22:11 zentotem

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, dc730507493849d6a0cd4064e8f99fa1b5acf25c

zentotem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/zentotem/zentotem.go:17:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/zentotem/zentotem.go:24:	MakeRequests		83.3%
github.com/prebid/prebid-server/v3/adapters/zentotem/zentotem.go:49:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/zentotem/zentotem.go:62:	MakeBids		88.9%
total:									(statements)		89.2%

github-actions[bot] avatar Nov 13 '24 22:11 github-actions[bot]

@ccorbo can you please review?

bsardo avatar Jan 06 '25 16:01 bsardo

@zentotem please see my comments above.

bsardo avatar Feb 17 '25 04:02 bsardo

@zentotem just a reminder to see my comments above.

bsardo avatar Mar 24 '25 02:03 bsardo

@zentotem please see the above comments.

bsardo avatar Apr 14 '25 18:04 bsardo

@zentotem are you still planning to move forward with this PR?

bsardo avatar Apr 28 '25 02:04 bsardo

@zentotem I sent an email to the provided email address reminding about the unresolved comments. We will close this PR in two weeks if we do not receive a response. If we close it you can always open it again at a later date if you decide to continue work.

bsardo avatar Jun 13 '25 01:06 bsardo

Hi! We will get back to solving the problems now

dogmat1k avatar Jun 23 '25 17:06 dogmat1k

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, ead335d901ea14e85bdbf179e9d35c91beef9fe3

zentotem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/zentotem/zentotem.go:17:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/zentotem/zentotem.go:24:	MakeRequests		83.3%
github.com/prebid/prebid-server/v3/adapters/zentotem/zentotem.go:49:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/zentotem/zentotem.go:62:	MakeBids		88.9%
total:									(statements)		89.2%

github-actions[bot] avatar Jun 24 '25 10:06 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 221cd794a6b161fb532342574a59c34c0ad0363c

zentotem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/zentotem/zentotem.go:17:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/zentotem/zentotem.go:24:	MakeRequests		83.3%
github.com/prebid/prebid-server/v3/adapters/zentotem/zentotem.go:49:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/zentotem/zentotem.go:62:	MakeBids		88.9%
total:									(statements)		89.2%

github-actions[bot] avatar Jun 24 '25 12:06 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 780d0930cd1c385678f513a23c1a954fc9b41ff9

zentotem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/zentotem/zentotem.go:17:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/zentotem/zentotem.go:24:	MakeRequests		83.3%
github.com/prebid/prebid-server/v3/adapters/zentotem/zentotem.go:49:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/zentotem/zentotem.go:62:	MakeBids		88.9%
total:									(statements)		89.2%

github-actions[bot] avatar Jun 24 '25 12:06 github-actions[bot]

All comments have been fixed, await approve

dobb2 avatar Jun 24 '25 13:06 dobb2