prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard
verified publisher icon prebid

Flipp: use height value from server response

Open MishelleBit opened this issue 1 year ago • 1 comments

Using standardHeight and compactHeight from server response. Modified some tests accordingly as well.

MishelleBit avatar Sep 25 '24 17:09 MishelleBit

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 70dec6e009082770859fc57098a6bf3b93fd7495

flipp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:49:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:57:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:75:	makeRequest		75.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:95:	processImp		88.6%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:171:	buildPrebidRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:188:	MakeBids		85.7%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:226:	getAdTypes		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:233:	buildBid		100.0%
github.com/prebid/prebid-server/v2/adapters/flipp/flipp.go:263:	paramsUserKeyPermitted	80.0%
total:								(statements)		89.3%

github-actions[bot] avatar Sep 25 '24 17:09 github-actions[bot]

Hi, could I please get two reviews to proceed with this change? Thank you @przemkaczmarek @bsardo @onkarvhanumante @minaguib @dlackty @dmitris @asweeney86 @hhhjort

MishelleBit avatar Oct 09 '24 18:10 MishelleBit

Hi @przemkaczmarek, I hope you're doing well. Can we get an update on this?

MishelleBit avatar Oct 22 '24 19:10 MishelleBit

Hello, could I please get another review to proceed with this change? Thank you @bsardo @onkarvhanumante @minaguib @dlackty @dmitris @asweeney86 @hhhjort

MishelleBit avatar Oct 23 '24 15:10 MishelleBit

Hi @bsardo , I hope you're doing well. Can we get an update on this?

MishelleBit avatar Oct 31 '24 21:10 MishelleBit

Hi @MishelleBit, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

bsardo avatar Nov 04 '24 17:11 bsardo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 18cf454678b00da6ae866fe3a1599ec3b7350933

flipp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:50:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:58:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:76:	makeRequest		75.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:96:	processImp		88.6%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:172:	buildPrebidRequest	100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:189:	MakeBids		85.7%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:227:	getAdTypes		100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:234:	buildBid		100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:264:	paramsUserKeyPermitted	80.0%
total:								(statements)		89.3%

github-actions[bot] avatar Nov 05 '24 22:11 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 18cf454678b00da6ae866fe3a1599ec3b7350933

flipp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:50:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:58:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:76:	makeRequest		75.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:96:	processImp		88.6%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:172:	buildPrebidRequest	100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:189:	MakeBids		85.7%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:227:	getAdTypes		100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:234:	buildBid		100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:264:	paramsUserKeyPermitted	80.0%
total:								(statements)		89.3%

github-actions[bot] avatar Nov 05 '24 22:11 github-actions[bot]

Hi @bsardo, done!

MishelleBit avatar Nov 05 '24 22:11 MishelleBit

Hi @bsardo I hope you're doing well, can we get an update?

MishelleBit avatar Nov 15 '24 15:11 MishelleBit

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, cbe75ab41fb5e12de4eff003273c58c167d942bc

flipp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:50:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:58:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:76:	makeRequest		75.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:96:	processImp		88.6%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:172:	buildPrebidRequest	100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:189:	MakeBids		85.7%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:227:	getAdTypes		100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:234:	buildBid		100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:271:	paramsUserKeyPermitted	80.0%
total:								(statements)		89.4%

github-actions[bot] avatar Nov 18 '24 18:11 github-actions[bot]

Thanks @SyntaxNode ! It should handle different types and i've set customeData to null in simple-banner-dtx.json

MishelleBit avatar Nov 18 '24 18:11 MishelleBit

Hi @przemkaczmarek can you please reapprove? thank you!

MishelleBit avatar Nov 25 '24 22:11 MishelleBit

Hi @SyntaxNode can you please reapprove? thank you!

MishelleBit avatar Nov 26 '24 18:11 MishelleBit

@SyntaxNode Hello, you previously approved can you please re-approve? thank you.

MishelleBit avatar Dec 05 '24 15:12 MishelleBit

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7c84694aa47fa9fc17ddb9f69134c06d76b4b410

flipp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:50:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:58:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:76:	makeRequest		75.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:96:	processImp		88.6%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:172:	buildPrebidRequest	100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:189:	MakeBids		85.7%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:227:	getAdTypes		100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:234:	buildBid		100.0%
github.com/prebid/prebid-server/v3/adapters/flipp/flipp.go:271:	paramsUserKeyPermitted	80.0%
total:								(statements)		89.4%

github-actions[bot] avatar Dec 10 '24 18:12 github-actions[bot]