prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

Zeta Global SSP Adapter: add 'sid' parameter, add audio support.

Open abermanov-zeta opened this issue 1 year ago • 1 comments

abermanov-zeta avatar Sep 25 '24 13:09 abermanov-zeta

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 01be5a323e73f6ea20c3d14d6589f61cc9e871f5

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:34:	MakeRequests		78.6%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:65:	getImpressionExt	75.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:82:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:87:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:121:	getMediaTypeForBid	100.0%
total:											(statements)		88.9%

github-actions[bot] avatar Sep 25 '24 13:09 github-actions[bot]

Hi @abermanov-zeta, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

bsardo avatar Nov 04 '24 17:11 bsardo

Closing this MR due to https://github.com/prebid/prebid-server/pull/3849

abermanov-zeta avatar Nov 21 '24 15:11 abermanov-zeta

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 02f5a13ff9416028bde3ab456dde3b85152a2e2d

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:35:	MakeRequests		78.6%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:66:	getImpressionExt	75.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:83:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:88:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:122:	getMediaTypeForBid	100.0%
total:											(statements)		88.9%

github-actions[bot] avatar Feb 05 '25 20:02 github-actions[bot]

Hi @abermanov-zeta, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

@bsardo Done, thank you.

abermanov-zeta avatar Feb 05 '25 20:02 abermanov-zeta

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 8fd20e31ec0767085c49734c7d18c307714a4d23

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:35:	MakeRequests		78.6%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:66:	getImpressionExt	75.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:83:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:88:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:122:	getMediaTypeForBid	100.0%
total:											(statements)		88.9%

github-actions[bot] avatar Feb 19 '25 20:02 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5dd01d4dc1a9de403584b940e94c4b47ba2e0386

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:35:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:66:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:83:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:88:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:122:	getMediaTypeForBid	100.0%
total:											(statements)		94.4%

github-actions[bot] avatar Mar 04 '25 14:03 github-actions[bot]