Silvermob: Use mtype and add global host

[freemmy]

Metdia type detection by mtype rather than by imp object global host for geo-based routing added

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, 8a597e38e55678cef92da4bef53f05aca558f87d

silvermob

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/silvermob/silvermob.go:21:	isValidHost			100.0%
github.com/prebid/prebid-server/v2/adapters/silvermob/silvermob.go:26:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/silvermob/silvermob.go:38:	GetHeaders			91.7%
github.com/prebid/prebid-server/v2/adapters/silvermob/silvermob.go:61:	MakeRequests			91.3%
github.com/prebid/prebid-server/v2/adapters/silvermob/silvermob.go:112:	getImpressionExt		85.7%
github.com/prebid/prebid-server/v2/adapters/silvermob/silvermob.go:128:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/silvermob/silvermob.go:139:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/silvermob/silvermob.go:197:	getBidMediaTypeFromMtype	83.3%
total:									(statements)			93.6%

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, 457a76d2e5c124f7ceaa582f5d931bd3627dcead

silvermob

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/silvermob/silvermob.go:21:	isValidHost			100.0%
github.com/prebid/prebid-server/v2/adapters/silvermob/silvermob.go:26:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/silvermob/silvermob.go:38:	GetHeaders			91.7%
github.com/prebid/prebid-server/v2/adapters/silvermob/silvermob.go:61:	MakeRequests			91.3%
github.com/prebid/prebid-server/v2/adapters/silvermob/silvermob.go:112:	getImpressionExt		85.7%
github.com/prebid/prebid-server/v2/adapters/silvermob/silvermob.go:128:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/silvermob/silvermob.go:139:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/silvermob/silvermob.go:198:	getBidMediaTypeFromMtype	83.3%
total:									(statements)			93.7%

[bsardo]

Hi @freemmy, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, 2e4b140b475130b0bd7789743347a323f47d3290

silvermob

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/silvermob/silvermob.go:22:	isValidHost			100.0%
github.com/prebid/prebid-server/v3/adapters/silvermob/silvermob.go:27:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/silvermob/silvermob.go:39:	GetHeaders			91.7%
github.com/prebid/prebid-server/v3/adapters/silvermob/silvermob.go:62:	MakeRequests			91.3%
github.com/prebid/prebid-server/v3/adapters/silvermob/silvermob.go:113:	getImpressionExt		85.7%
github.com/prebid/prebid-server/v3/adapters/silvermob/silvermob.go:129:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v3/adapters/silvermob/silvermob.go:140:	MakeBids			100.0%
github.com/prebid/prebid-server/v3/adapters/silvermob/silvermob.go:199:	getBidMediaTypeFromMtype	83.3%
total:									(statements)			93.7%

[freemmy]

Hi @freemmy, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

Done, could you please review? Thanks in advance

[freemmy]

Hi @freemmy, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

Hello @bsardo, could you let us know when the review might be completed? Our pull request has been pending for 2 months now, and during this time, our adapter has an issue where bid requests containing both video and banner are always treated as video. This prevents us from serving banners in such cases. As a result, OpenWrap isn’t functioning properly with 300x250 and 320x480 ad sizes.

[bsardo]

Hi @freemmy, sorry for the delay. We've been overloaded. I'll give this a look today.

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, 65354fa59065419621a4048776c120ff3cf39bd4

silvermob

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/silvermob/silvermob.go:22:	isValidHost			100.0%
github.com/prebid/prebid-server/v3/adapters/silvermob/silvermob.go:27:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/silvermob/silvermob.go:39:	GetHeaders			91.7%
github.com/prebid/prebid-server/v3/adapters/silvermob/silvermob.go:62:	MakeRequests			91.3%
github.com/prebid/prebid-server/v3/adapters/silvermob/silvermob.go:113:	getImpressionExt		85.7%
github.com/prebid/prebid-server/v3/adapters/silvermob/silvermob.go:129:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v3/adapters/silvermob/silvermob.go:140:	MakeBids			100.0%
github.com/prebid/prebid-server/v3/adapters/silvermob/silvermob.go:199:	getBidMediaTypeFromMtype	100.0%
total:									(statements)			94.9%