prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard
verified publisher icon prebid

New adapter: Ads Interactive

Open AdsInteractive opened this issue 1 year ago • 1 comments

doc - https://github.com/prebid/prebid.github.io/pull/5602

AdsInteractive avatar Sep 17 '24 21:09 AdsInteractive

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 77fe565567333aff10489dbb37bac35ff888aa50

ads_interactive

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:35:	MakeRequests	88.2%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:91:	makeRequest	85.7%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:109:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:145:	getBidType	100.0%
total:											(statements)	92.4%

github-actions[bot] avatar Sep 17 '24 21:09 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, ad4f8d5a499707cc2446da2b8eae19c441a34fc2

ads_interactive

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:35:	MakeRequests	88.2%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:91:	makeRequest	85.7%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:109:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:145:	getBidType	100.0%
total:											(statements)	92.4%

github-actions[bot] avatar Oct 11 '24 08:10 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 0cc30e34628272ad1b1db006eed2e0eb0e059888

ads_interactive

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:35:	MakeRequests	88.2%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:91:	makeRequest	85.7%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:109:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:145:	getBidType	100.0%
total:											(statements)	92.4%

github-actions[bot] avatar Oct 14 '24 13:10 github-actions[bot]

@bsardo we have already adsInteractive adapter. They use the same vendor-id

przemkaczmarek avatar Oct 22 '24 11:10 przemkaczmarek

@bsardo we have already adsInteractive adapter. They use the same vendor-id

@AdsInteractive we noticed that there is already an adsinteractive adapter in PBS with the same GVL ID and endpoint domain adsinteractive.com. We also see that there are two adapters in prebid.js for Ads Interactive. Can you help us understand why there are two?

bsardo avatar Oct 24 '24 14:10 bsardo

@bsardo the existing adapter is used for one platform and this one is for ours. We have no relation to the existing adsinteractive

AdsInteractive avatar Oct 28 '24 10:10 AdsInteractive

Hi @AdsInteractive, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

bsardo avatar Nov 04 '24 16:11 bsardo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 46a6d48a7a3c91690f8668c42c7df75975679a72

ads_interactive

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/ads_interactive/ads_interactive.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/ads_interactive/ads_interactive.go:35:	MakeRequests	88.2%
github.com/prebid/prebid-server/v3/adapters/ads_interactive/ads_interactive.go:91:	makeRequest	85.7%
github.com/prebid/prebid-server/v3/adapters/ads_interactive/ads_interactive.go:109:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/ads_interactive/ads_interactive.go:145:	getBidType	100.0%
total:											(statements)	92.4%

github-actions[bot] avatar Nov 05 '24 14:11 github-actions[bot]

@bsardo done

AdsInteractive avatar Nov 05 '24 14:11 AdsInteractive

@AdsInteractive - I disagree with this statement:

We have no relation to the existing adsinteractive

  1. The GVL ID is the same.
  2. The contact address is the same

We need you to help us understand the actual relationship between adsinteractive and ads_interactive. There are 3 options:

  1. ads_interactive is a new implementation and branding, and we should deprecate adsinteractive in a future major release.
  2. ads_interactive is really the same company and this PR should be updated to just replace adsinteractive.
  3. ads_interactive is truly a different company. You will provide different GVL ID and different contact address.

Based on the fact that this same confusion exists in Prebid.js, I suspect you'll choose option 1.

bretg avatar Nov 05 '24 17:11 bretg

@bretg thanks for the reply, new clarifications have appeared. Our case is the first option: ads_interactive is a new implementation and branding, and we should deprecate adsinteractive in a future major release

AdsInteractive avatar Nov 07 '24 10:11 AdsInteractive

I've added "remove adsinteractive adapter" to the PBS 4.0 issue. Please make sure that you update the documentation to make it clear which branding is active.

bretg avatar Nov 07 '24 14:11 bretg

I've added "remove adsinteractive adapter" to the PBS 4.0 issue. Please make sure that you update the documentation to make it clear which branding is active.

@bretg thanks, doc PR - https://github.com/prebid/prebid.github.io/pull/5732

AdsInteractive avatar Nov 27 '24 08:11 AdsInteractive

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 0fb1b094db07d123a866b3b1d8e361ef8c19706c

ads_interactive

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/ads_interactive/ads_interactive.go:29:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/ads_interactive/ads_interactive.go:36:	MakeRequests	88.2%
github.com/prebid/prebid-server/v3/adapters/ads_interactive/ads_interactive.go:92:	makeRequest	85.7%
github.com/prebid/prebid-server/v3/adapters/ads_interactive/ads_interactive.go:110:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/ads_interactive/ads_interactive.go:146:	getBidType	100.0%
total:											(statements)	92.4%

github-actions[bot] avatar Jan 15 '25 12:01 github-actions[bot]