prebid-server
prebid-server copied to clipboard
prebid
Rubicon: No longer copy certain FPD fields
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 8c4f33ea1190659f73324c10b82e36602bf7d088
rubicon
Refer here for heat map coverage report
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:183: resolveVideoSizeId 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:201: appendTrackerToUrl 87.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:217: Builder 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:228: updateRequestTo26 92.3%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:253: MakeRequests 81.3%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:570: createImpsToExtMap 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:589: prepareImpsToExtMap 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:608: splitMultiFormatImp 61.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:645: resolveBidFloor 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:653: updateImpRpTargetWithFpdAttributes 76.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:735: extractDfpAdUnitCode 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:745: isNotKeyPathError 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:749: addStringAttribute 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:753: addStringArrayAttribute 0.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:757: updateUserRpTargetWithFpdAttributes 70.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:787: updateExtWithIabAttribute 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:796: populateFirstPartyDataAttributes 92.9%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:824: isStringArray 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:834: isBoolArray 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:844: convertToStringArray 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:855: rawJSONToMap 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:863: mapFromRawJSON 80.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:872: getSegmentIdsToCopy 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:892: contains 75.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:901: isVideo 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:910: isFullyPopulatedVideo 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:915: resolveNativeObject 88.2%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:947: setImpNative 82.4%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:976: MakeBids 92.2%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1076: mapImpIdToCpmOverride 90.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1094: resolveAdm 87.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1109: cmpOverrideFromBidRequest 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1118: updateBidExtWithMetaNetworkId 82.4%
total: (statements) 84.3%
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 5af01876eb36c68958ff2ad35a6c9e6f048c6efe
rubicon
Refer here for heat map coverage report
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:185: resolveVideoSizeId 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:203: appendTrackerToUrl 87.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:219: Builder 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:231: updateRequestTo26 92.3%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:256: MakeRequests 81.3%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:573: createImpsToExtMap 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:592: prepareImpsToExtMap 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:611: splitMultiFormatImp 61.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:648: resolveBidFloor 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:656: updateImpRpTarget 77.8%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:743: extractDfpAdUnitCode 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:753: isNotKeyPathError 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:757: addStringAttribute 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:761: addStringArrayAttribute 0.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:765: updateUserRpTargetWithFpdAttributes 70.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:795: updateExtWithIabAttribute 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:804: populateFirstPartyDataAttributes 92.9%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:832: isStringArray 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:842: isBoolArray 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:852: convertToStringArray 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:863: rawJSONToMap 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:871: mapFromRawJSON 80.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:880: getSegmentIdsToCopy 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:900: contains 75.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:909: isVideo 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:918: isFullyPopulatedVideo 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:923: resolveNativeObject 88.2%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:955: setImpNative 82.4%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:984: MakeBids 92.2%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1084: mapImpIdToCpmOverride 90.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1102: resolveAdm 87.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1117: cmpOverrideFromBidRequest 100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1126: updateBidExtWithMetaNetworkId 82.4%
total: (statements) 84.4%
Hi @CTMBNara, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3.
For example:
import (
"github.com/prebid/prebid-server/v3/adapters"
)
As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, e54afb422b85c41a1e3df7cbb424d458ac7838a7
rubicon
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:187: resolveVideoSizeId 100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:205: appendTrackerToUrl 87.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:221: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:233: updateRequestTo26 92.3%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:258: MakeRequests 81.3%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:575: createImpsToExtMap 100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:594: prepareImpsToExtMap 100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:613: splitMultiFormatImp 61.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:650: resolveBidFloor 100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:658: updateImpRpTarget 77.8%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:745: extractDfpAdUnitCode 100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:755: isNotKeyPathError 100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:759: addStringAttribute 100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:763: addStringArrayAttribute 0.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:767: updateUserRpTargetWithFpdAttributes 70.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:797: updateExtWithIabAttribute 100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:806: populateFirstPartyDataAttributes 92.9%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:834: isStringArray 100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:844: isBoolArray 100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:854: convertToStringArray 100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:865: rawJSONToMap 100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:873: mapFromRawJSON 80.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:882: getSegmentIdsToCopy 100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:902: contains 75.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:911: isVideo 100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:920: isFullyPopulatedVideo 100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:925: resolveNativeObject 88.2%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:957: setImpNative 82.4%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:986: MakeBids 92.2%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1086: mapImpIdToCpmOverride 90.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1104: resolveAdm 87.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1119: cmpOverrideFromBidRequest 100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1128: updateBidExtWithMetaNetworkId 82.4%
total: (statements) 84.4%