prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard
verified publisher icon prebid

Rubicom: Remove `imp.ext.context` references

Open CTMBNara opened this issue 1 year ago • 1 comments

CTMBNara avatar Sep 13 '24 11:09 CTMBNara

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 0b4e6737d84f3bd15b2e4d328283dd1f2990d8ef

rubicon

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:178:	resolveVideoSizeId			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:196:	appendTrackerToUrl			87.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:212:	Builder					100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:223:	updateRequestTo26			92.3%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:248:	MakeRequests				81.3%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:565:	createImpsToExtMap			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:584:	prepareImpsToExtMap			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:603:	splitMultiFormatImp			61.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:640:	resolveBidFloor				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:648:	updateImpRpTargetWithFpdAttributes	80.4%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:739:	extractDfpAdUnitCode			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:747:	isNotKeyPathError			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:751:	addStringAttribute			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:755:	addStringArrayAttribute			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:759:	updateUserRpTargetWithFpdAttributes	70.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:789:	updateExtWithIabAttribute		100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:798:	populateFirstPartyDataAttributes	92.9%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:826:	isStringArray				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:836:	isBoolArray				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:846:	convertToStringArray			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:857:	rawJSONToMap				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:865:	mapFromRawJSON				80.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:874:	getSegmentIdsToCopy			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:894:	contains				75.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:903:	isVideo					100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:912:	isFullyPopulatedVideo			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:917:	resolveNativeObject			88.2%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:949:	setImpNative				82.4%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:978:	MakeBids				92.2%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1078:	mapImpIdToCpmOverride			90.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1096:	resolveAdm				87.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1111:	cmpOverrideFromBidRequest		100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1120:	updateBidExtWithMetaNetworkId		82.4%
total:									(statements)				84.8%

github-actions[bot] avatar Sep 13 '24 11:09 github-actions[bot]

@MaksymTeqBlaze can you please review once conflicts have been resolved?

bsardo avatar Nov 12 '24 15:11 bsardo

@CTMBNara please resolve conflicts

MaksymTeqBlaze avatar Dec 11 '24 15:12 MaksymTeqBlaze

@CTMBNara when you get a minute, please resolve conflicts and address the outstanding comment. Thanks!

bsardo avatar Jan 27 '25 16:01 bsardo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, e149c431760b8de18e1f1aaa17ac883b1e9779ff

rubicon

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:173:	appendTrackerToUrl			87.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:189:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:201:	updateRequestTo26			92.3%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:226:	MakeRequests				80.6%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:539:	createImpsToExtMap			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:558:	prepareImpsToExtMap			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:577:	splitMultiFormatImp			61.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:614:	resolveBidFloor				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:622:	updateImpRpTarget			76.6%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:700:	extractDfpAdUnitCode			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:708:	isNotKeyPathError			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:712:	addStringAttribute			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:716:	addStringArrayAttribute			0.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:720:	updateUserRpTargetWithFpdAttributes	70.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:750:	updateExtWithIabAttribute		100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:759:	populateFirstPartyDataAttributes	92.9%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:787:	isStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:797:	isBoolArray				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:807:	convertToStringArray			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:818:	rawJSONToMap				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:826:	mapFromRawJSON				80.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:835:	getSegmentIdsToCopy			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:855:	contains				75.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:864:	isVideo					100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:873:	isFullyPopulatedVideo			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:878:	resolveNativeObject			88.2%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:910:	setImpNative				82.4%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:939:	MakeBids				92.2%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1039:	mapImpIdToCpmOverride			90.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1057:	resolveAdm				87.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1072:	cmpOverrideFromBidRequest		100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1081:	updateBidExtWithMetaNetworkId		82.4%
total:									(statements)				83.9%

github-actions[bot] avatar Feb 18 '25 17:02 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 298cd9244e602416d8c507c23fa78adbdd625c09

rubicon

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:173:	appendTrackerToUrl			87.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:189:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:201:	updateRequestTo26			92.3%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:226:	MakeRequests				80.6%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:539:	createImpsToExtMap			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:558:	prepareImpsToExtMap			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:577:	splitMultiFormatImp			61.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:614:	resolveBidFloor				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:622:	updateImpRpTarget			76.6%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:700:	extractDfpAdUnitCode			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:708:	isNotKeyPathError			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:712:	addStringAttribute			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:716:	addStringArrayAttribute			0.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:720:	updateUserRpTargetWithFpdAttributes	70.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:750:	updateExtWithIabAttribute		100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:759:	populateFirstPartyDataAttributes	92.9%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:787:	isStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:797:	isBoolArray				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:807:	convertToStringArray			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:818:	rawJSONToMap				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:826:	mapFromRawJSON				80.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:835:	getSegmentIdsToCopy			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:855:	contains				75.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:864:	isVideo					100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:873:	isFullyPopulatedVideo			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:878:	resolveNativeObject			88.2%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:910:	setImpNative				82.4%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:939:	MakeBids				92.2%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1039:	mapImpIdToCpmOverride			90.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1057:	resolveAdm				87.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1072:	cmpOverrideFromBidRequest		100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1081:	updateBidExtWithMetaNetworkId		82.4%
total:									(statements)				83.9%

github-actions[bot] avatar Feb 18 '25 22:02 github-actions[bot]