prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard
verified publisher icon prebid

New Adapter: Connatix

Open patrickszeleczki-cnx opened this issue 1 year ago • 3 comments

Docs: https://github.com/prebid/prebid.github.io/pull/5595

patrickszeleczki-cnx avatar Sep 12 '24 14:09 patrickszeleczki-cnx

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 08242bef6c99aab32c4c72bb6bfc2ff5796a8008

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:23:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:35:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:81:	MakeBids		80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:121:	validateAndBuildImpExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:134:	validateConnatixExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:143:	splitRequests		90.9%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:185:	buildRequestImp		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:233:	buildDisplayManageVer	55.6%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:251:	getBidType		100.0%
total:									(statements)		74.5%

github-actions[bot] avatar Sep 12 '24 14:09 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 55ec262c8a72e37a54a9190ccb8f4a327e9afb31

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:23:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:35:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:81:	MakeBids		80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:121:	validateAndBuildImpExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:134:	validateConnatixExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:143:	splitRequests		90.9%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:185:	buildRequestImp		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:233:	buildDisplayManageVer	55.6%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:251:	getBidType		100.0%
total:									(statements)		74.5%

github-actions[bot] avatar Sep 26 '24 10:09 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 28ed966e87dbf7fdb953e2aa1012a6fde215f9d7

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:23:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:35:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:81:	MakeBids		80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:121:	validateAndBuildImpExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:134:	validateConnatixExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:143:	splitRequests		90.9%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:185:	buildRequestImp		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:233:	buildDisplayManageVer	55.6%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:251:	getBidType		100.0%
total:									(statements)		74.5%

github-actions[bot] avatar Sep 26 '24 11:09 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4c7a620e4d2e4e525d0b45a395efa664a1adfe3e

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:23:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:35:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:81:	MakeBids		80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:121:	validateAndBuildImpExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:134:	validateConnatixExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:143:	splitRequests		92.9%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:197:	buildRequestImp		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:245:	buildDisplayManageVer	55.6%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:263:	getBidType		100.0%
total:									(statements)		75.9%

github-actions[bot] avatar Oct 02 '24 10:10 github-actions[bot]

@patrickszeleczki Please add more JSON tests (Check which lines of code are not covered by tests). We usually approve PRs when the test coverage is more than 85%.

przemkaczmarek avatar Oct 02 '24 14:10 przemkaczmarek

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 15bdaa220c8be5bc7ce775fea8fc1b15d07e11b1

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:23:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:35:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:81:	MakeBids		80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:121:	validateAndBuildImpExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:134:	validateConnatixExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:143:	splitRequests		92.9%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:197:	buildRequestImp		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:245:	buildDisplayManageVer	55.6%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:263:	getBidType		100.0%
total:									(statements)		75.9%

github-actions[bot] avatar Oct 03 '24 10:10 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 9d7904250c54ef2f3c15add3eb4dbbda91d0656e

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:23:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:35:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:81:	MakeBids		80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:121:	validateAndBuildImpExt	83.3%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:134:	validateConnatixExt	100.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:143:	splitRequests		92.9%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:197:	buildRequestImp		90.5%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:245:	buildDisplayManageVer	55.6%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:263:	getBidType		100.0%
total:									(statements)		87.9%

github-actions[bot] avatar Oct 03 '24 10:10 github-actions[bot]

@bsardo does it look alright to you too? thanks!

patrickszeleczki-cnx avatar Oct 09 '24 09:10 patrickszeleczki-cnx

ping @bsardo thank you!

patrickszeleczki-cnx avatar Oct 29 '24 11:10 patrickszeleczki-cnx

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4be32f5c62c55c0a27fb60af059e8021cf825f61

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:24:	Builder			80.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:36:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:82:	MakeBids		80.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:122:	validateAndBuildImpExt	83.3%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:135:	validateConnatixExt	100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:144:	splitRequests		92.9%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:198:	buildRequestImp		90.5%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:246:	buildDisplayManageVer	55.6%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:264:	getBidType		100.0%
total:									(statements)		87.9%

github-actions[bot] avatar Nov 04 '24 11:11 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5e74e5c401601b2373e487139c502ca2e8f0b8c2

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:24:	Builder			80.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:36:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:82:	MakeBids		80.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:122:	validateAndBuildImpExt	83.3%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:135:	validateConnatixExt	100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:144:	splitRequests		92.9%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:198:	buildRequestImp		90.5%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:246:	buildDisplayManageVer	55.6%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:264:	getBidType		100.0%
total:									(statements)		87.9%

github-actions[bot] avatar Nov 11 '24 11:11 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 38d26e9bb73ef8acb8a96a80ff3305a2cc921b28

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:24:	Builder			80.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:36:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:71:	MakeBids		95.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:111:	validateAndBuildImpExt	100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:120:	splitRequests		93.1%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:176:	buildRequestImp		100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:218:	buildDisplayManagerVer	88.9%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:236:	getBidType		100.0%
total:									(statements)		95.2%

github-actions[bot] avatar Nov 11 '24 11:11 github-actions[bot]

@bsardo Thanks a lot for the thorough review and I really appreciate the clear suggestions for the new tests and the small improvement suggestions! 🙇

patrickszeleczki-cnx avatar Nov 11 '24 11:11 patrickszeleczki-cnx

ping @bsardo @przemkaczmarek thank you!

patrickszeleczki-cnx avatar Nov 22 '24 08:11 patrickszeleczki-cnx

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b4b1be26bc7052f33eba834d03e29238ed159d7c

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:24:	Builder			80.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:36:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:71:	MakeBids		95.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:111:	validateAndBuildImpExt	100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:120:	splitRequests		93.1%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:176:	buildRequestImp		100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:218:	buildDisplayManagerVer	88.9%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:236:	getBidType		100.0%
total:									(statements)		95.2%

github-actions[bot] avatar Dec 03 '24 11:12 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, a8891b946a2a6556950e6f3fee223377bc798f1b

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:30:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:65:	MakeBids		95.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:105:	validateAndBuildImpExt	100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:114:	splitRequests		93.1%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:170:	buildRequestImp		100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:212:	buildDisplayManagerVer	88.9%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:230:	getBidType		100.0%
total:									(statements)		96.1%

github-actions[bot] avatar Dec 03 '24 12:12 github-actions[bot]

@bsardo @przemkaczmarek do you have any estimate when this will be included in a release? thank you!

patrickszeleczki-cnx avatar Dec 05 '24 08:12 patrickszeleczki-cnx