prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard
verified publisher icon prebid

New Adapter: Kobler

Open TommyHPettersen opened this issue 1 year ago • 1 comments

docs - https://github.com/prebid/prebid.github.io/pull/5587

TommyHPettersen avatar Sep 06 '24 13:09 TommyHPettersen

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, c65ede15b62f348a45bdf9a68ff96d92c93ac113

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:26:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:35:	MakeRequests		85.7%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:67:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:98:	getEndpoint		100.0%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:106:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:121:	convertImpCurrency	100.0%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:135:	contains		50.0%
total:									(statements)		92.2%

github-actions[bot] avatar Sep 10 '24 12:09 github-actions[bot]

Hello @bsardo @przemkaczmarek, what can I expect as an estimate for merging this, and is there anything I can contribute with to move this forward?

TommyHPettersen avatar Oct 07 '24 11:10 TommyHPettersen

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, c9a87a6a2ec94165beeb16b897929c81f937fc6a

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:26:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:35:	MakeRequests		87.5%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:70:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:101:	getEndpoint		100.0%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:109:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:124:	convertImpCurrency	100.0%
github.com/prebid/prebid-server/v2/adapters/kobler/kobler.go:138:	contains		50.0%
total:									(statements)		92.5%

github-actions[bot] avatar Oct 11 '24 11:10 github-actions[bot]

@przemkaczmarek Hello, is there anything blocking this for a second reviewer and is there anything I can do to help speed this process up?

TommyHPettersen avatar Oct 21 '24 07:10 TommyHPettersen

Thank you for the review so far. @bsardo When do you think you have time to review this?

TommyHPettersen avatar Nov 04 '24 07:11 TommyHPettersen

Hi @TommyHPettersen, I'll give this a look as soon as the following is addressed.

We recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

bsardo avatar Nov 04 '24 16:11 bsardo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, a18ec121caf3240893895cfc24df636a066d824b

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:26:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:35:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:70:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:101:	getEndpoint		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:109:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:124:	convertImpCurrency	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:138:	contains		50.0%
total:									(statements)		92.5%

github-actions[bot] avatar Nov 05 '24 09:11 github-actions[bot]

Thank you for the response @bsardo, i have now updated all the package imports to v3 and the test suite passes.

Hope this helps!

TommyHPettersen avatar Nov 05 '24 09:11 TommyHPettersen

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, a67d266a85a06026c25933abf713d3f5bf030663

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:27:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:36:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:71:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:102:	getEndpoint		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:110:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:125:	convertImpCurrency	100.0%
total:									(statements)		95.9%

github-actions[bot] avatar Nov 18 '24 08:11 github-actions[bot]

Thank you @SyntaxNode and @przemkaczmarek for the reviews, hoping we can get this merged soon as this PR has been open for a while!

TommyHPettersen avatar Nov 18 '24 09:11 TommyHPettersen

Hello @VeronikaSolovei9, we have been waiting for this PR to be merged for 3 months and as far as I understand you guys have been updating to v3 in that time which might have blocked a lot of PRs, is there anything else I can do here to help get this PR merged? Thank you!

TommyHPettersen avatar Dec 05 '24 08:12 TommyHPettersen

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, e6b4eebf98ca1554feddcfd4ce69edcd796cc194

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:27:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:36:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:71:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:104:	getEndpoint		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:112:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:127:	convertImpCurrency	100.0%
total:									(statements)		95.9%

github-actions[bot] avatar Dec 09 '24 09:12 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, aba06b9f12cc00b65f7cfadd646e28901914cb39

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:27:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:36:	MakeRequests		80.6%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:103:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:134:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:149:	convertImpCurrency	100.0%
total:									(statements)		90.2%

github-actions[bot] avatar Dec 12 '24 11:12 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, c51b0e5c3f90b97c628794f05794c53a8180c733

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:27:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:36:	MakeRequests		80.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:101:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:132:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:147:	convertImpCurrency	100.0%
total:									(statements)		90.0%

github-actions[bot] avatar Dec 13 '24 09:12 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, cf56a4d963ffb12a0a227428d6cb188de9e3d47d

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:27:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:36:	MakeRequests		80.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:101:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:132:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:147:	convertImpCurrency	100.0%
total:									(statements)		90.0%

github-actions[bot] avatar Dec 16 '24 11:12 github-actions[bot]

Happy new years @VeronikaSolovei9, @bsardo, @przemkaczmarek, and @SyntaxNode!

Do any of you have any info on when this PR will be merged and included in the master branch, and/or when this will be included in a release?

Hope to hear from any of you soon, and thank you for the work so far!

TommyHPettersen avatar Jan 03 '25 09:01 TommyHPettersen

@TommyHPettersen - I happened to notice that the docs piece here is missing. First your file at https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/kobler.md needs to declare "pbs: true" in the header.

Then also noticed that the adapter is not supporting either the "priceFloor" or the "dealId" parameter.

We need to get the documentation aligned - please update this file and add a note on those parameters that they're only supported in Prebid.js

thanks

bretg avatar Jan 21 '25 14:01 bretg

@TommyHPettersen - I happened to notice that the docs piece here is missing. First your file at https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/kobler.md needs to declare "pbs: true" in the header.

Then also noticed that the adapter is not supporting either the "priceFloor" or the "dealId" parameter.

We need to get the documentation aligned - please update this file and add a note on those parameters that they're only supported in Prebid.js

thanks

@bretg We actually have a PR open for the docs here that is approved https://github.com/prebid/prebid.github.io/pull/5587

TommyHPettersen avatar Jan 22 '25 10:01 TommyHPettersen